Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: restrict access to protected routes with firewall #4745

Merged
merged 1 commit into from Mar 7, 2024
Merged

api: restrict access to protected routes with firewall #4745

merged 1 commit into from Mar 7, 2024

Conversation

BacLuc
Copy link
Contributor

@BacLuc BacLuc commented Mar 6, 2024

Else the queries are executed without a user filter, which keeps our database busy.

@carlobeltrame carlobeltrame added the deploy! Creates a feature branch deployment for this PR label Mar 6, 2024
carlobeltrame
carlobeltrame approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, will test tomorrow on the deployment

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited

⛔ Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@BacLuc
api: restrict access to protected routes with firewall
14354f8 
Else the queries are executed without a user filter,
which keeps our database busy.
@BacLuc BacLuc force-pushed the api-restrict-requests-in-firewall branch from 225393b to 14354f8 Compare March 6, 2024 23:01
carlobeltrame
carlobeltrame approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my manual tests were successful, including registering, email confirmation, login, OAuth login, password change, email change, invitation sending, invitation accepting, invitation rejecting, and some smoke tests across different views and both prints.

@carlobeltrame carlobeltrame added this pull request to the merge queue Mar 7, 2024
Merged via the queue into ecamp:devel with commit 24b9995 Mar 7, 2024
32 checks passed
@BacLuc BacLuc deleted the api-restrict-requests-in-firewall branch March 7, 2024 13:45
This was referenced Mar 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelmeister manuelmeister manuelmeister approved these changes

@carlobeltrame carlobeltrame carlobeltrame approved these changes

Assignees
No one assigned
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BacLuc @manuelmeister @carlobeltrame