Copy category from other category or from activity #4823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
carlobeltrame
force-pushed
the
copy-category
branch
from
0076dec
to
b3b30a0
Compare
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
pmattmann
approved these changes
Mar 26, 2024
manuelmeister
previously requested changes
Mar 26, 2024
| <v-btn v-show="clipboardPermission === 'prompt'" v-on="on"> | ||
| <v-icon left>mdi-information-outline</v-icon> | ||
| {{ | ||
| $tc('components.campAdmin.dialogCategoryCreate.copyPasteCategoryOrActivity') |
There was a problem hiding this comment.
Not sure if this is too verbose
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
carlobeltrame
force-pushed
the
copy-category
branch
from
21db621
to
e644613
Compare
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
BacLuc
approved these changes
Mar 30, 2024
| @@ -23,10 +104,17 @@ import { categoryRoute } from '@/router.js' | |||
| import DialogForm from '@/components/dialog/DialogForm.vue' | |||
| import DialogBase from '@/components/dialog/DialogBase.vue' | |||
| import DialogCategoryForm from './DialogCategoryForm.vue' | |||
| import PopoverPrompt from '../prompt/PopoverPrompt.vue' | |||
| import router from '../../router.js' | |||
There was a problem hiding this comment.
Shouldn't this be an absolute import?
| ) | ||
| }) | ||
| .then(async (url) => { | ||
| this.copyActivitySource = await ( |
There was a problem hiding this comment.
is this better?
i think 2 lines would make this easier to read
| @@ -272,7 +272,7 @@ export default { | |||
| async copyUrlToClipboard() { | |||
| try { | |||
| const res = await navigator.permissions.query({ name: 'clipboard-read' }) | |||
| if (res.state == 'prompt') { | |||
| if (res.state === 'prompt') { | |||
There was a problem hiding this comment.
We need a lint rule for that
There was a problem hiding this comment.
Yes, that would be good.
| @@ -16,14 +16,24 @@ | |||
|
|
|||
| <template #title-actions> | |||
| <TogglePaperSize v-model="isPaperDisplaySize" /> | |||
| <v-menu v-if="isManager" offset-y> | |||
| <v-menu offset-y> | |||
There was a problem hiding this comment.
Ah, like this you can copy categories from camps where you are not a manager, nice.
There was a problem hiding this comment.
Exactly. Same as for the activities which we already allow to copy. Sharing is caring.
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
carlobeltrame
force-pushed
the
copy-category
branch
from
7fe7f5f
to
fee746c
Compare
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
carlobeltrame
force-pushed
the
copy-category
branch
from
fee746c
to
ccfdcfc
Compare
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
This was referenced Apr 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #3993, but for pasting and duplicating categories. A pasted category can be based on another category (from the same or a different camp), or on an activity (from the same or a different camp).
Backend implementation is hilariously simple with the system we already have set up, props to @pmattmann!
I did this because it is a requested feature (with medium prio), and also I felt the need myself when setting up a camp recently.