Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature / Picasso full size #5112

Merged
merged 6 commits into from
May 4, 2024
Merged

Feature / Picasso full size #5112

merged 6 commits into from
May 4, 2024

Conversation

pmattmann
Copy link
Member

@pmattmann pmattmann commented May 2, 2024 •
edited
Loading

Since we no longer have a status line at the bottom (Commit ID), we have a too large gap below the Picasso.
This PR enlarges the Picasso - and reduces the gap.

Old:
image

New:
image

@pmattmann
Copy link
Member Author

fixed also:

  • (+) Button Position
  • Picasso ViewBox Size, when Filters visible

image

@usu usu added the deploy! Creates a feature branch deployment for this PR label May 4, 2024
@usu usu temporarily deployed to feature-branch May 4, 2024 11:34 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024 •
edited
Loading

⛔ Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

manuelmeister
manuelmeister requested changes May 4, 2024
View reviewed changes
Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Cool that you fixed the filter gap as well. Can you please use the resize observer we already have or implement unobserve/disconnect and unmount?

frontend/src/views/camp/CampProgram.vue Outdated Show resolved Hide resolved
frontend/src/components/program/ScheduleEntryFilters.vue Outdated Show resolved Hide resolved
@manuelmeister manuelmeister added this pull request to the merge queue May 4, 2024
Merged via the queue into ecamp:devel with commit d8108f6 May 4, 2024
32 checks passed
@pmattmann pmattmann deleted the feature/picasso-size branch May 4, 2024 17:13
@BacLuc BacLuc mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usu usu usu approved these changes

@BacLuc BacLuc BacLuc approved these changes

@manuelmeister manuelmeister manuelmeister approved these changes

Assignees
No one assigned
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmattmann @usu @BacLuc @manuelmeister