Merge pull request #2858 from ecency/nt/img-ratio-fix

Nt/img ratio fix
ecency · Apr 16, 2024 · a9fcac0 · a9fcac0
2 parents 50ee58e + a757bfb
commit a9fcac0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/components/autoHeightImage/autoHeightImage.tsx b/src/components/autoHeightImage/autoHeightImage.tsx
@@ -25,10 +25,11 @@ export const AutoHeightImage = ({
   const _initialHeight = useMemo(() => {
     let _height = contentWidth / (16 / 9);
     if (metadata && metadata.image && metadata.image_ratios) {
+
       metadata.image_ratios.forEach((_ratio, index) => {
         const url = metadata.image[index];
 
-        if (url && !Number.isNaN(_ratio)) {
+        if (url && Number.isFinite(_ratio) && _ratio !== 0) {
           const poxifiedUrl = proxifyImageSrc(
             url,
             undefined,
@@ -40,7 +41,6 @@ export const AutoHeightImage = ({
           );
 
           if (imgUrl === poxifiedUrl) {
-            const _ratio = metadata.image_ratios[index];
             _height = contentWidth / _ratio;
           }
         }

diff --git a/src/utils/editor.ts b/src/utils/editor.ts
@@ -268,7 +268,7 @@ export const extractMetadata = async ({
               (width, height) => {
                 resolve(width / height);
               },
-              () => resolve(0),
+              () => resolve(NaN),
             );
           });
         })