Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nt/img ratio fix #2858

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Nt/img ratio fix #2858

merged 2 commits into from
Apr 16, 2024

Conversation

noumantahir
Copy link
Collaborator

What does this PR?

apparently image_ratios in post reported were set to all zeros, that causing infinity img heights. fixed by taking steps below.

  • making sure 0 is not processed as ratio
  • making sure 0 is not set as ration upon ratio calculation failure

Issue number

https://discord.com/channels/@me/920267778190086205/1228823626250453062

Screenshots/Video

Screen.Recording.2024-04-16.at.12.28.37.mov

@noumantahir noumantahir requested a review from feruzm April 16, 2024 07:31
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@feruzm feruzm merged commit a9fcac0 into development Apr 16, 2024
@feruzm feruzm deleted the nt/img-ratio-fix branch April 16, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants