Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/login page change #1279

Closed

Conversation

shawnpringle
Copy link
Collaborator

Displays Keychani login dialog by default when the keychain extension is installed

@@ -84,6 +90,48 @@ export class LoginKc extends BaseComponent<LoginKcProps, LoginKcState> {
toggleUIProp("login");
};

userSelect = (user: User) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use async/await function

@feruzm
Copy link
Member

feruzm commented Aug 7, 2023

@shawnpringle This PR focuses on preference (Keychain) as main login method. While our team maintains Hivesigner and equally safe and convenient login method, even that is presented as secondary login option just like Keychain. Our main motivation showing Username and Password field as a first login method, connected to our onboarding structure. People get username and password during signup, they should be able to use those directly without complication of extra services. For that, we would like to keep that option to decrease confusion. Let us utilize Discussions boards (https://github.com/ecency/ecency-vision/discussions) to talk about features before their implementation so we can learn and brainstorm ideas together before putting actual work effort. Thank you very much for your effort! 🙇 👍

@feruzm feruzm closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants