Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/edit community settings #1297

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Bug/edit community settings #1297

merged 2 commits into from
Mar 28, 2023

Conversation

MTSaeed
Copy link
Collaborator

@MTSaeed MTSaeed commented Mar 28, 2023

Bug Description:

I think I found an issue. On a brand new community, I went to the community page with my own (ADMIN) account.
I clicked on "Edit Settings" and spent some time entering Description and Rules.
Then I clicked "Save". It took a few seconds, there was no error reported.
The info I typed appeared on the left-hand side of the Community Page.
I refreshed the page, F5, and all the info disappeared. Waited some time and refreshed several times, it still show the initial info, meaning Desc & Rules are empty. It didn't cross my mind I could get to such problem so I have to write it again. Probably better use a text editor this time first.

What does this PR?
Saved the community settings after clicking on save button.

Steps to reproduce

  1. Login with admin account of any community.
    2.Go to profile and then click on communities. click on any community.
  2. Click on the edit settings button that is the on the left side of the community page.
  3. Write any thing in description and rules and then click on save. after clicking on save you will see the latest changing.

Issue number

fixes #1045

Screenshot / videos

edit-community-settings.mp4

@MTSaeed
Copy link
Collaborator Author

MTSaeed commented Mar 28, 2023

community-setting-test

Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit 77ffcd6 into development Mar 28, 2023
@feruzm feruzm deleted the bug/edit-community-settings branch March 28, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: This needs checking
2 participants