-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mini.files spaces after and before Title #1062
Comments
If possible, it would be something along the lines of customizing window example, but with However, quick tests showed that title is somewhat special, as it indeed updates when navigating horizontally. I am afraid, declaring title "special" and not designed to be customized is a reasonable approach here. |
@echasnovski, Thanks for atleast trying to help me I just want to make the title/path to be more emphasized and make it look appealing to me. :) btw I really loved your plugins but is it possible to add a "padding" so that the Icons itself is not really close to the border? |
Icons are the result of applying Here is an example of how to override it so that there is an extra space before an icon: local prefix = function(fs_entry)
local icon, hl = MiniFiles.default_prefix(fs_entry)
return ' ' .. icon, hl
end
require('mini.files').setup({ content = { prefix = prefix } }) |
@echasnovski, Thanks for very fast response now it works as I intended and looks nice. But my current concern is about the link you've provided in customizing window example why is it that the "Title" property when assigned by a function that returns the current working directory as a title doesn't automatically add spaces like the a normal title would do. |
I don't really understand the question. By default titles in floating windows are not padded with spaces. The reason customization doesn't apply for titles is because they are a bit special as described in the original response:
|
Previously these events were not triggered during cursor movement. This resulted in a better performance for anyone wanting to create an autocommand for them (less triggers is better). However, this resulted in too much constraints put on *what exactly* can be customized in window outlook. For example, customizing how title looks or even window height was not really possible because those get overridden by the internal logic. It looks like "emit `MiniFilesWindowUpdate` event whenever window config is updated" is a better approach. Resolve #1140 Resolve #1062
@6H075T2, after some recent changes, I think adding space padding to title now should be possible. You can follow the newly added example (without the This use case even has a dedicated test in the hope that it will keep working. I changed my mind about this issue because height also could not be customized (see #1140). As the root cause has revealed to be the same (intentional blocking of too frequent |
@echasnovski, I never thought you'll give my request some attention since it's I've considered it silly because I don't think anyone even want this feature and possibly even go againts your project principle, I really appreciate your effort to make this possible. <3 I'm looking forward to your mini.statuscolumn plugin 😊 |
To be perfectly honest, I indeed did not intend to account for this (because they indeed are special). It was somewhat of a coincidence that the key problem that blocked this also happened to block other customizations. That felt a bit too much, so decided to address it. Besides, I briefly tried it, and can confirm that it indeed looks beautiful :)
Me too. However, quick tests couple of weeks ago showed that it might be reasonable to wait until 0.11 release, because current Nightly has some significant quality of life improvements in 'statuscolumn'. We'll see. |
Hi, @echasnovski I've noticed this visual bug ↓ Thank you for this wonderful update with bookmarks, its nice to have :> |
That's expected because width of windows are fixed and can be configured inside |
I forgot to include that the Neovim's window is minimize and not in Fullscreen that's why it happens. 🤦 |
Contributing guidelines
Module(s)
mini.files
Description
Really liked this plugin a lot and configuring this plugin to my liking but I couldn't figure out on how I can configure this plugin to add spaces with its Title to make it look like the Footer below.
I'm currently learning how to code in Lua and please have patience with me.
The text was updated successfully, but these errors were encountered: