check for dropTarget not being null in addDropTarget #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a problem with Drag and Drop interaction with echopointng Tree. When a tree node is collapsed and nodes from the branch contain drop targets the targets may not be found in the DOM tree any longer. When the ExtrasDragSource.MessageProcessor processes init messages in processInit() to add the drop targets a null element is referenced. I changed the code to check that dropTarget isn't null. I hit this back in 2009 on a school project before this project was in github. I recently was working on the project porting to maven and saw these files were in maven central, but hit the problem again.
|
Thank you for your contribution, @rreganjr |
|
I'm using a fixed version in my local maven repo so I'm good for now. thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with Drag and Drop interaction with echopointng Tree. When a tree node is collapsed and nodes from the branch contain drop targets the targets may not be found in the DOM tree any longer. When the ExtrasDragSource.MessageProcessor processes init messages in processInit() to add the drop targets a null element is referenced. I changed the code to check that dropTarget isn't null. I hit this back in 2009 on a school project before this project was in github. I recently was working on the project porting to maven and saw these files were in maven central, but hit the problem again.