Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Notion2md's API is not working because of its global variables #28

Closed
echo724 opened this issue Jan 30, 2022 · 0 comments
Closed

Some Notion2md's API is not working because of its global variables #28

echo724 opened this issue Jan 30, 2022 · 0 comments

Comments

@echo724
Copy link
Owner

echo724 commented Jan 30, 2022 •
edited

Because the global variable in the code, it is not easy to call some api in your package. Thus, I recommend to pass the notion client as the parameter other than the global variable.

Issued by @Asynchro-Epool #24
echo724 added a commit that referenced this issue Feb 3, 2022
@echo724
refactor: Create method to get children blocks instead of calling not…
6159d59 
…ion_client_object #28
@echo724 echo724 closed this as completed Feb 3, 2022
YouXam pushed a commit to YouXam/notion2md that referenced this issue Nov 3, 2023
@echo724
refactor: Create method to get children blocks instead of calling not…
47aa035 
…ion_client_object echo724#28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@echo724