Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a problem with synced block. #24

Closed
panwanke opened this issue Jan 27, 2022 · 3 comments
Closed

There is a problem with synced block. #24

panwanke opened this issue Jan 27, 2022 · 3 comments

Comments

@panwanke
Copy link

  1. When the page have synced block, there is some problem.
  2. When the page have many pictures, just one picture would be saved if these pictures have default name(Untitled.png). And the
  3. In the code, some GLobal variables may cause some troubles.
@echo724
Copy link
Owner

echo724 commented Jan 28, 2022

Thank you for notifying the issues you have. However, can you explain more detail on 3 issues? For example, what error message show up about 3 issues, or what input data you used(a Notion Page or a specific block)?

@panwanke
Copy link
Author

Thanks for your reply.

For the first issue, If you convert a notion page to markdown file, which contains sync block, you will get text "sync_block is not surported" and the content in the sync block sometimes would be converted to "code format" in the final markdown file.

For the second issue, since these picture have same default name, so you finally get one picture called "Untitled.png" because the others are covered.

For the third issue, because the global variable in the code, it is not easy to call some api in your package. Thus, I recommend to pass the notion client as the parameter other than the global variable.

@echo724
Copy link
Owner

echo724 commented Jan 30, 2022

Thanks. I separated those, and will fix one by one of them.

@echo724 echo724 closed this as completed Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants