-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retain to type export #109
Merged
azoitl
merged 8 commits into
eclipse-4diac:freeze
from
MandKastner:AddRetainToTypeExport
May 13, 2024
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b10a467
add retain flag to type exporter
MandKastner 6b8a19e
restructure generation
MandKastner 48b5f50
replace hardcoded strings
MandKastner 6f55d94
replace hardcoded strings
MandKastner 101363a
move filter argument into seperate method
MandKastner ffcaf2a
remove boolean variable from setInitialValues
MandKastner 9556f12
remove comments
MandKastner 778001e
move empty line
MandKastner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that yesterday but can you please move the
cold) {
part into the if and else, and in the else only add){
Because if there are no retain variables the cold param is not needed.
And as we are at it: In 4diac FORTE we have the coding guideline that function parameters stat with pa. So please change
cold
topaCold
.