Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new workload always having the state "removed" #102

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

christoph-hamm
Copy link
Contributor

@christoph-hamm christoph-hamm commented Nov 22, 2023

If the "podman ps" cache is not reset before starting the state checker, the state checker will get the old "podman ps" result, this result will not contain the new workload, the state checker will assume the workload has be removed and will stop immediately.

Definition of Done

The PR shall be merged only if all items mentioned in
CONTRIBUTING.md
have been followed. In case an item is not applicable as described, please provide a short explanation in the description.

If the "podman ps" cache is not reset before starting the state
checker, the state checker will get the old "podman ps" result, this
result will not contain the new workload, the state checker will
assume the workload has be removed and will stop immediately.
@krucod3 krucod3 mentioned this pull request Nov 23, 2023
1 task
@windsource windsource added the bug Something isn't working. Issue will appear in the change log "Bug Fixes" label Nov 23, 2023
Copy link
Contributor

@krucod3 krucod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@krucod3 krucod3 merged commit 4beb916 into main Nov 23, 2023
6 checks passed
@krucod3 krucod3 deleted the fix_new_workloads_always_state_removed branch November 23, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. Issue will appear in the change log "Bug Fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants