-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ank apply command to CLI #180
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Maybe one suggestion and meant optionally (It expects how much workloads we expect on average touched with this new command): The ank apply command outputs the workloads it has touched to the console within |
@inf17101 Not sure what you mean. When I call ❯ ank apply databroker.yaml
agent_names={"agent_A"}
error: ExecutionError("Failed get response from server in time (timeout=3s).") However, I do not think that we shoud limit those. |
If you would not have the response errors (because of missing @christoph-hamm' PR) then it would print the workloads as well and potentially spam the output if there are many to touch. But it is anyway meant optionally. But I thought it is maybe helpful to mention, because today's applications would handle such case. I think it is not a bad idea to restrict output that can be not calculated how much it would be. |
do folding of workload names when versobse mode is off
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supporting multiple agents in yaml files provided to ank apply
is required.
This comment was marked as resolved.
This comment was marked as resolved.
Currently it is not supported and you need to tell via the |
When an application developer provides an application with workloads for different agents then one manifest should be enough to describe the deployment of that application. So I think it required. |
Currently the output does not look very clear. What about using a table structure as output? $ ank apply file1.yaml file2.yaml
WORKLOAD AGENT STATUS FILENAME
databroker agent_a OK file1.yaml
nginx agent_b Error file1.yaml
db agent_b OK file2.yaml |
Co-authored-by: Holger Dormann <holger.dormann@elektrobit.com>
Okay, I like your suggestion! I understood that the current output contains some kind of redundant information. I will adapt it. |
fixed failing stests
introduced table display for apply manifests
fix failing utests
The issue has been fixed. |
addedd missing utests apply suggested changes related to manifest parsing
I have created two workloads with:
and the output looks OK. But when I delete those workloads with:
the agent names are wrong. As the agent names are not known they column AGENT shall be removed for the output of |
print no agent names on operation remove
Issue-Id: #26
removed unsupported fields in test data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK from a user perspective. Still some approval from technical perspective required.
There is a merge conflict in this PR. @lingnoi could you resolve it, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay for me. @christoph-hamm is reviewing fixes of his findings in the swdesign.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only two small findings.
Co-authored-by: Christoph Hamm <130038849+christoph-hamm@users.noreply.github.com>
Co-authored-by: Christoph Hamm <130038849+christoph-hamm@users.noreply.github.com>
removed underscore
Issues: #26
Added ank apply command
Definition of Done
The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.