Add cache for podman ps #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue-Id: #1
Issue-Id: #1
krucod3
requested changes
Nov 17, 2023
There was a problem hiding this comment.
Finished with the review of the code. There were some small findings that I directly fixed. The fixes are in single commits s.t. they can be reverted if you don't agree with them.
What we definitely have to take care of is the bug with the pod states in case one of the pods in a workloads disappears (see below for details).
I still need to review the tests for the podman_cli.
Issue-Id: #1
krucod3
reviewed
Nov 20, 2023
Issue-Id: #1 Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
krucod3
reviewed
Nov 21, 2023
windsource
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: #1
Currently for each podman and podman-kube workload the Ankaios agent calls the command
podman psonce per second.This needs a lot CPU resources.
The Ankaios agent shall cache podman ps result, and use the result for all podman workloads.
Definition of Done
The PR shall be merged only if all items mentioned in
CONTRIBUTING.md
have been followed. In case an item is not applicable as described, please provide a short explanation in the description.