-
Notifications
You must be signed in to change notification settings - Fork 783
Replace multiple HttpClients with Jetty #1689
Comments
Thanks for looking into this! |
The current state looks like this: Bundles using Apache HttpClient 3.x (org.apache.commons.httpclient) - 6: Bundles using Apache HttpClient 4.x (org.apache.http.) - 1: Bundles using Jetty Client (org.eclipse.jetty.client) - 3: Bundle using javax.ws.rs.client: I could not find any info about : Miele, Helios and ATSAdvanced. As it can be seen, most of the bundles depend on the old Apache HttpClient 3.x. I will start digging into this list, but the main problem remains how we can assure, that no existing functionality is broken? Will developers would like to test the bindings after an eventual change? |
Please ONLY regard the bundles in smarthome and openhab2-addons repository - for openHAB 1, it is absolutely ok to use something else and openhab-core simply requires this for the compatibility layer. |
OK, I was not sure if I can ignore them, I will edit the list then. |
Miele and Helios are bindings that are still (@kaikreuzer ahum ;-) ) in a (OH2) PR. ATSAdvanced is a binding that I can not publish due to SDK license constraints |
There is already an issue for the FS Internet Radio binding: #682 but AFAIK there is no work done for it yet. |
Bundles using package org.eclipse.smarthome.io.net.http from org.eclipse.smarthome.io.net (that currently depends on Apache HttpClient 3.x): openhab2-addons\addons\binding\org.openhab.binding.astro\META-INF\MANIFEST.MF |
kaikreuzer wrote:
I found some missing dependencies in the SmartHome target platform:
In openHAB target platform is located in openhab-deps-repo:
|
@svilenvul Just add this commit to your PR and the Jetty client is part of the smarthome.target: kaikreuzer@56d8ab6 |
@kaikreuzer thanks |
Apache HttpClient is replaced in 3 bindings: - in Ipp binding it is removed the dependency to Apache HttpClient 4.x with the replacement of the cups4j distribution (cups4j.runnable-0.6.4.jar includes the dependency to Apache HttpClient) - Squeezebox binding (Apache HttpClient 3.x replaced with Jetty) - Autelis binding (Apache HttpClient 3.x replaced with Jetty) With this PR all dependencies to Apache HttpClient 3.x and 4.x are removed. (see eclipse-archived/smarthome#1689) Signed-off-by: Svilen Valkanov <svilen.valkanov@musala.com>
The problem is discussed already in the forum.
I could not find any opened other close issue about that.
I will paste here some of the posts:
Jochen Hiller wrote on Sat, 08 August 2015 09:30
Kai Kreuzer wrote on Sat, 08 August 2015 21:03
karel goderis wrote on Tue, 18 August 2015 20:21
I would like to work on the issue. As the last post is almost an year old, I will take a look one more time at the existing state, and most importantly, which bindings will be affected.
The text was updated successfully, but these errors were encountered: