Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

add missing label & description to channelDTO #1007

Merged
merged 1 commit into from
Feb 9, 2016

Conversation

marcelrv
Copy link
Contributor

@marcelrv marcelrv commented Feb 9, 2016

addresses openhab/org.openhab.ui.habmin#120

Signed-off-by: Marcel Verpaalen marcel@verpaalen.com

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv
Copy link
Contributor Author

marcelrv commented Feb 9, 2016

@cdjackson in case the label & description are null, do you want to have the UI pull them from the channeltype or is it better to do the test here inside the rest interface?

@cdjackson
Copy link
Contributor

I thought this was already done when the XML was read (for static definitions). If so, I think it should be done in the ESH side when creating a channel (if that's where it's done for static definitions) so that static and dynamic channels are handled the same way?

@kaikreuzer
Copy link
Contributor

lgtm. I think the question of how and when to derive label/desc from the type is not directly related to this PR as it imho should not take place in the REST resource, but rather either when creating channels internally or only within the UI itself.

kaikreuzer added a commit that referenced this pull request Feb 9, 2016
add missing label & description to channelDTO
@kaikreuzer kaikreuzer merged commit 6f0d440 into eclipse-archived:master Feb 9, 2016
@marcelrv marcelrv deleted the channelDTO branch February 9, 2016 17:18
@kaikreuzer kaikreuzer modified the milestone: 0.8.0.b5 May 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants