Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert WeavingAdaptor generated class map optimisation #304

Merged
merged 1 commit into from
Apr 8, 2024

Commits on Apr 8, 2024

  1. Revert WeavingAdaptor generated class map optimisation

    This was introduced in commit 8a4aa03 of PR #278 contribution as part
    of the #279 fix. The contributor thought that the generated closure
    class entries were never used, but in fact AJDT class OSGiWeavingAdaptor
    relies on the presence of those entries.
    
    To the best of my present knowledge, it looks as if this change was the
    root cause of eclipse-aspectj/ajdt#57.
    Therefore, I reverted it, simultaneously refactoring Iterator::remove
    usage to delete entries from the map to Collection::removeIf.
    
    Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
    kriegaex committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    8c88314 View commit details
    Browse the repository at this point in the history