Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebViewer: Add calender picker for date report parameter #1356

Closed
speckyspooky opened this issue Jul 4, 2023 · 6 comments
Closed

WebViewer: Add calender picker for date report parameter #1356

speckyspooky opened this issue Jul 4, 2023 · 6 comments
Assignees
Labels
Enhancement Small change to improve the current supported functionality
Milestone

Comments

@speckyspooky
Copy link
Contributor

According to an older request #939 to add a "dade picker" I plan an implementation based on the HTML5
to add the option of the types "date", "datetime-local" and "time" to the parameter-dialog.

The plan is to use the standard behavior of the browser based on the input-tag.
Therefore the display of the datepicker is dependent on the browser-implementation. The browser Chrome & Edge (Chromium based) will have the best support by standard (without additional libraries). The browser FirFox will sho only the date-picker without support of datetime- and time-picker.

But it will be a good improvement and we will also be able to add a better date-picker-library later in a next step.

The plan is not to change the JSP-fragment by default. The better way is that we will have new options on eclipse-dialog of the parameters based on the data type to select an additional kind of display "Display As".

Plan of eclipse-dialog

Folie1

Date-Picker, pilot implementation displayed on Chrome

Folie2

@speckyspooky speckyspooky self-assigned this Jul 4, 2023
@speckyspooky speckyspooky added the Enhancement Small change to improve the current supported functionality label Jul 4, 2023
@claesrosell
Copy link
Contributor

@speckyspooky I have an "almost done" implementation of this that I have not pushed. What is left is support for jsp-fragments, some exception regarding context initialization from Jetty.
Would you be interested in this?

@speckyspooky
Copy link
Contributor Author

@claesrosell
Yes, I'm interested on it, so I can compare it with my version.
I have done my implementation through the whole parameter line and do currently some advanced tests.

@claesrosell
Copy link
Contributor

Here is a link to my branch : https://github.com/claesrosell/birt/tree/926-calender-picker-for-date-report-parameter
It is not rebased against master.

@speckyspooky
Copy link
Contributor Author

@claesrosell
I reviewed your changes and there is a main difference to my version.
You have defined a new display type for the parameter "DATE_CTRL".
My version instead is based on new "Display As"-style type and the display type keeps a textbox.
With the display-style I handle all version of date, datetime, time and the according options of only date w/ or w/o time picker and the version of short or long time picker.

I would prefer the "Display As"-version. Do you thought about this way?

@claesrosell
Copy link
Contributor

No, I did not consider that. I do not have a preferred way of solving this. I just tried to mimic how other controls were implemented.

speckyspooky added a commit that referenced this issue Jul 9, 2023
…#1359)

* WebViewer, enhance parameter display options with date picker (#1356)

* Added spaces before step="1" concat
@speckyspooky
Copy link
Contributor Author

The enhancement was merged with #1359

speckyspooky added a commit that referenced this issue Jul 14, 2023
* WebViewer, enhance parameter display options with date picker (#1356)

* Added spaces before step="1" concat

* Activated the "dynamic" selection list for display type "Radio Button"
(#1360)

* Fixed warnings and typos of variable names which was detected at
PRs #1356 & #1360

---------

Co-authored-by: Ed Merks <Ed.Merks@gmail.com>
@claesrosell claesrosell added this to the 4.14 milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Small change to improve the current supported functionality
Projects
None yet
Development

No branches or pull requests

2 participants