Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings and typos which was detected at #1356 and #1360 #1364

Merged

Conversation

speckyspooky
Copy link
Contributor

Fix warnings and typos which was detected at #1356 and #1360

@speckyspooky
Copy link
Contributor Author

@wimjongman & @merks
Hello guys, I created that PR to fix some java-warnings of my last changes.
The build process stopped at the start of the "Maven build"-steps because there seems to be a dependency missing.

Have you an idea how we can fix it - rerun was stopped with the same error:

Error: Failed to resolve target definition file:/home/runner/work/birt/birt/build/org.eclipse.birt.target/org.eclipse.birt.target.target: Could not find "org.eclipse.mylyn.bugzilla_feature.feature.group/0.0.0" in the repositories of the current location -> [Help 1]

@merks
Copy link
Contributor

merks commented Jul 14, 2023

Mylyn has been changing the IDs of most of its features. I'll need to make updates accordingly.

merks added a commit to merks/birt that referenced this pull request Jul 14, 2023
@speckyspooky
Copy link
Contributor Author

Thanks of your fast investigation

merks added a commit that referenced this pull request Jul 14, 2023
Regenerate the target platform accordingly.

#1364
@merks
Copy link
Contributor

merks commented Jul 14, 2023

The build with the update target platform was successful so I updated the branch of this PR...

@speckyspooky speckyspooky merged commit 132b8b8 into eclipse-birt:master Jul 14, 2023
3 checks passed
@speckyspooky speckyspooky added this to the 4.14 milestone Jul 15, 2023
@speckyspooky speckyspooky self-assigned this Jul 15, 2023
@speckyspooky speckyspooky deleted the fix_warnings_and_typos_1356_1360 branch September 16, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants