Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregation button disabled #856

Closed
jochenberger opened this issue Mar 9, 2022 · 4 comments · Fixed by #857
Closed

Aggregation button disabled #856

jochenberger opened this issue Mar 9, 2022 · 4 comments · Fixed by #857
Milestone
4.9

Comments

@jochenberger
Copy link

Hi,

we tried to upgrade to 4.9. The results look very promising (:clinking_glasses:), but it looks as if there is still an issue with the aggregation button. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=511212 for reference.

Cheers,
Jochen

Originally posted by @jochenberger in #855
claesrosell added a commit to claesrosell/birt that referenced this issue Mar 9, 2022
@claesrosell
Aggregation is disabled in charting eclipse-birt#856
395a213 
Enabled aggregation. Seems to have been a negation wrong. Also expanded
the default IChartUIHelper.useDataSetRow() implementation to a simple
startsWith("data") check previously used in the enableAddEditor()
method-
@claesrosell
Copy link
Contributor

I have made a fix for this, that is building now. The build will be available here: https://github.com/eclipse/birt/actions/runs/1959493255
Please try it out.

@wimjongman wimjongman added this to the 4.9 milestone Mar 10, 2022
@jochenberger
Copy link
Author

@claesrosell, the fix works for us. Thanks for the quick action.

@wimjongman wimjongman linked a pull request Mar 10, 2022 that will close this issue
Aggregation is disabled in charting #856 #857
Merged
@speckyspooky
Copy link
Contributor

@claesrosell
I tested the original-report with rcp-version-4.9 and confirm too. The fix works and the function editor is now usable.
Thanks to your side!

rcp-designer-4 9

claesrosell added a commit that referenced this issue Mar 11, 2022
@claesrosell
Aggregation is disabled in charting #856 (#857)
63a5c3c 
Enabled aggregation. Seems to have been a negation wrong. Also expanded
the default IChartUIHelper.useDataSetRow() implementation to a simple
startsWith("data") check previously used in the enableAddEditor()
method-
@wimjongman
Copy link
Contributor

Thanks, Claes. Another quality patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.9
Development

Successfully merging a pull request may close this issue.

Aggregation is disabled in charting #856 claesrosell/birt
4 participants
@wimjongman @jochenberger @claesrosell @speckyspooky