Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregation is disabled in charting #856 #857

Conversation

claesrosell
Copy link
Contributor

Enabled aggregation again. Seems to have been a negation wrong after refactoring. Also expanded
the default IChartUIHelper.useDataSetRow() implementation to a simple startsWith("data") check previously used in the enableAddEditor() method

Enabled aggregation. Seems to have been a negation wrong. Also expanded
the default IChartUIHelper.useDataSetRow() implementation to a simple
startsWith("data") check previously used in the enableAddEditor()
method-
@claesrosell
Copy link
Contributor Author

The change in ChartUIHelperBase.useDataSetRow(Object reportItem, String expression) is taken from the old test used in the BaseDataDefinitionComponent.enableAggEditor() prior to the refactoring done in commit b40bee0 , however the useDataSetRow() method is now used in other places as well and may effect those. According to the javadoc the method should:
"Return true if expression uses binding that contains data set row directly or indirectly"
but did only return "false" in the only implementation.
I think that this is a minimal start for a useDataSetRow() implementation, we can expand on it in the future when our knowledge of the code base has increased.

@wimjongman wimjongman added this to the 4.9 milestone Mar 10, 2022
@claesrosell
Copy link
Contributor Author

qs-wang Can you provide any input on this? I got the feeling that you have worked on Birt previously.

@wimjongman wimjongman linked an issue Mar 10, 2022 that may be closed by this pull request
@wimjongman
Copy link
Contributor

Claes, we have to close master until we have released 4.9. I am fine taking this in but you have to do it now.

Otherwise, we retarget this for 4.10

@claesrosell claesrosell merged commit 63a5c3c into eclipse-birt:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregation button disabled
2 participants