Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected eclipse warnings and added comments (#1695) #1697

Merged
merged 1 commit into from
May 18, 2024
Merged

Corrected eclipse warnings and added comments (#1695) #1697

merged 1 commit into from
May 18, 2024

Conversation

speckyspooky
Copy link
Contributor

No description provided.

@speckyspooky speckyspooky added this to the 4.16 milestone May 18, 2024
@speckyspooky speckyspooky requested a review from merks May 18, 2024 12:59
@speckyspooky speckyspooky self-assigned this May 18, 2024
@speckyspooky
Copy link
Contributor Author

Based on the enhancement of the query editor change I saw the eclipse hints.
This is a seperated PR to remove the warnings and add the missing documentation.

merks
merks approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@speckyspooky speckyspooky merged commit 9d526c7 into eclipse-birt:master May 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merks merks merks approved these changes

Assignees

@speckyspooky speckyspooky

Labels
Documentation
Projects
None yet
Milestone
4.16
Development

Successfully merging this pull request may close these issues.
2 participants
@speckyspooky @merks