Oomph setup

[ruspl-afed]

Initial version of setup script
Target definition uses existing file but not yet activated for some reason

[merks]

You have to use the value of the name attribute, not the file name:

<target includeMode="feature" name="BIRT Photon target platform">

It's looked up like this:

https://git.eclipse.org/c/oomph/org.eclipse.oomph.git/tree/plugins/org.eclipse.oomph.util.pde/src/org/eclipse/oomph/util/pde/TargetPlatformUtil.java#n246

[ruspl-afed]

You have to use the value of the name attribute, not the file name:

Thank you Ed @merks , it works after switching to attribute name

[ruspl-afed]

@wimjongman I have "just" 113 compilation errors after applying this script that hopefully not related with script itself, please have a look.

[wimjongman]

Are the compilation errors in a test bundle?

[ruspl-afed]

@wimjongman with #678 applied I have 89 Java errors all in org.eclipse.birt.report.viewer.tests/test/org/eclipse/birt/report/viewer/mock

[wimjongman]

Thanks! Please see the windowbuilder README.MD file. Can you add an entry like that?

https://github.com/eclipse/windowbuilder/blob/master/README.md#2-create-an-eclipse-development-environment

[wimjongman]

@wimjongman with #678 applied I have 89 Java errors all in org.eclipse.birt.report.viewer.tests/test/org/eclipse/birt/report/viewer/mock

Should be fixed with #680

[ruspl-afed]

Thanks! Please see the windowbuilder README.MD file. Can you add an entry like that?

https://github.com/eclipse/windowbuilder/blob/master/README.md#2-create-an-eclipse-development-environment

@wimjongman you can have a look here: https://github.com/eclipse/birt/tree/oomph_setup

[wimjongman]

I get an error message:

[ruspl-afed]

I'm afraid we can test it only after merging, since the URL has reference to master. Or do you want me to remove readme change and create dedicated PR @wimjongman ?

[wimjongman]

Here is the URL with reference to oomph_setup branch

https://www.eclipse.org/setups/installer/?url=https://raw.githubusercontent.com/eclipse/birt/oomph_setup/build/org.eclipse.birt.releng/BIRT.setup&show=true

[ruspl-afed]

Here is the URL with reference to oomph_setup branch

https://www.eclipse.org/setups/installer/?url=https://raw.githubusercontent.com/eclipse/birt/oomph_setup/build/org.eclipse.birt.releng/BIRT.setup&show=true

Ooops. You are right. I think you need to click "next" on installer to go to "Project" page and then apply the URL. On the page from screenshot you selects what product should "host" the install.

[wimjongman]

Yes, on the second page I have to create a project with this setup URL. For windowbuilder I don't need to do that...

The second setup task asks me to install wtp. Should we not begin with that if it is required?

[wimjongman]

Can we also apply the project set file from the root of the directory?

[ruspl-afed]

For windowbuilder I don't need to do that

I'll take a look what is the magic there

The second setup task asks me to install wtp

No idea why, never seen this before. But I was testing it via Eclipse Installer

Can we also apply the project set file from the root of the directory?

It somehow managed to escape my pattern "In same repository as org.eclipse.birt"

[ruspl-afed]

For windowbuilder I don't need to do that

I'll take a look what is the magic there

I looked at the windowbuilder script. WindowBuilderConfiguration.setup is a kind of wrapping "Product" script around another "Project" script WindowBuilder.setup

Currently we have only "Project" script for BIRT and need to add a "Product" one to make this button fully usable

[wimjongman]

Ok, #680 is merged and a good bunch of tests is running again. I'm moving on to fixing the next set of tests. With #680 merged, we should see no more errors after oomph is done.

[wimjongman]

Alexander, can you rebase this one?

[wimjongman]

Good to go, Alexander?

[ruspl-afed]

Wim, I would merge it.
And then I can try to create another one for "Product".

[wimjongman]

Thanks!!!

By the way, "Signed-off-by:" is no longer required.