Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report viewer failing again. #649 #733

Merged
merged 7 commits into from
Nov 25, 2021
Merged

Report viewer failing again. #649 #733

merged 7 commits into from
Nov 25, 2021

Conversation

claesrosell
Copy link
Contributor

Please review

@claesrosell
Report viewer failing again eclipse-birt#649
88146be 
Removed the upper version limit for javax.servlet and javax.servlet.http
since javax.servlet 4+ is used.
@claesrosell
Report viewer failing again eclipse-birt#649
f03c0dd 
Moved to a WebAppContext based configuration instead of a mix of Webapp
Bundle / ContextHandler. Also explicitly added WebXmlConfiguration
support
@claesrosell
Report viewer failing again eclipse-birt#649
0a66240 
Added org.eclipse.jetty:apache-jsp to the targetplatform, configured jsp
InstanceManager in WebAppContext, added all jsp dependencies to Viewer
bundle and the debug configuration.
@claesrosell
Report viewer failing again eclipse-birt#649
e17c806 
Removed all the pre-compiled servlet and servlet-mappings from web.xml.
I think these should be added automatically during pre-compilation
@claesrosell
Report viewer failing again eclipse-birt#649
86df4b0 
Fixed invalid target platform definition.
@hvbtup
Copy link
Contributor

hvbtup commented Nov 21, 2021

This is great!
The preview is working. I tested this from within Exclipse, not with the Maven build.
The SLF4J still not working. Did you commit the changes to make it work as well?

@wimjongman wimjongman linked an issue Nov 22, 2021 that may be closed by this pull request
Report viewer failing again. #649
Closed
@wimjongman
Copy link
Contributor

wimjongman commented Nov 22, 2021 •
edited
Loading

Thanks, Claes. Awesome work.

The local dev viewer is working but the product does not at this moment. It is failing with a 503.

Looking at the differences between my workspace and the product I see the following missing jetty items (in the product):

  • org.eclipse.birt.jetty.overlay_4.9.0.qualifier
  • org.eclipse.jetty.annotations_10.0.6
  • org.eclipse.jetty.jmx_10.0.6
  • org.eclipse.jetty.schemas_4.0.3 <-- ???
  • org.eclipse.jetty.servlet-api_4.0.6 <--

There are other differences, but let's add these first.

(not the issue -> see next comment)

@wimjongman
Copy link
Contributor

I have found the issue with the product. It seems that the extra entries in the web.xml which were removed by Claes, are automatically generated during the build.

Removing the generated data from the web.xml solves the previewer and allows to generate all formats.

The web.xml to change is here: plugins/org.eclipse.birt.report.viewer_4.9.0.v202111221047/birt/WEB-INF

@claesrosell
Copy link
Contributor Author

I will need to get the build environment up and running to solve this. I will try to do that tonight.
When I last tried that, three years ago, it was the precompilation of jsp that made me give up. I guess that it is needed for some of the deployment scenarios of the viewer though.

@claesrosell
Copy link
Contributor Author

I have tested this with the "org.eclipse.birt.designer-win32.win32.x86_64" product and it works for me.

@wimjongman wimjongman merged commit 2864e61 into eclipse-birt:master Nov 25, 2021
@wimjongman
Copy link
Contributor

Claes, you are marvelous. Thank you!!

@claesrosell claesrosell deleted the Report_viewer_failing_again._#649 branch November 25, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report viewer failing again.
3 participants
@claesrosell @hvbtup @wimjongman