Defective PPTX format in BIRT #813 #818
Conversation
Null guard for when DimensionType.parseUnit() fails in PPTXUtil.convertCssToEnum(). This happens typically when the cssDimension is "auto" for margins, which really should have a special case treatment in the TableWriter.endCell(). However, from the look of it, the "margin" code in endCell needs a lot of refactoring and should perhaps be done in other places in PPTXCanvas instead ( .drawText() etc )
|
Claes, there is something wrong with your account: https://accounts.eclipse.org/legal/eca/validation/92768 |
Never mind, I revalidated and now it is fine. There was a strange drop in the internet. I saw several independent servers failing at the same time. Maybe a glitch in the matrix... |
|
I needed to re-validate for some reason. |
|
The change in 4.9.0-20220208-win32 has solved the problem (in the pptx format for Powerpoint as well as LibreOffice). Could you please close this issue. |
|
@claesrosell can you squash and merge? |
|
As soon as I get my account properly configured. Hopefully I will have time to fix that tonight. 😎 |
Cool. Make sure that you always commit with your committer email address and not accidentally with your gmail. |
|
Woot!!!! 🎉🎉🎉 |
Null guard for when DimensionType.parseUnit() fails in
PPTXUtil.convertCssToEnum(). This happens typically when the
cssDimension is "auto" for margins, which really should have a special
case treatment in the TableWriter.endCell(). However, from the look of
it, the "margin" code in endCell needs a lot of refactoring and should
perhaps be done in other places in PPTXCanvas instead ( .drawText() etc
)