Support unsuccessful request responses #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a TSP request response is received with an unsuccessful status code and without a json object model, the parsing of the body as json was throwing an error and the status code was unavailable to the caller. Create the TspClientResponse with the plain text of the response, and make the model optional. Make the plain text available to the caller. Do not throw an error when the json object is absent. Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
MatthewKhouzam
requested changes
Dec 21, 2020
There was a problem hiding this comment.
eclipse-cdt-cloud/trace-server-protocol#43 (comment) please align with this? and mention it in the commit message.
MatthewKhouzam
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a TSP request response is received with an unsuccessful status code
and without a json object model, the parsing of the body as json was
throwing an error and the status code was unavailable to the caller.
Create the TspClientResponse with the plain text of the response, and
make the model optional. Make the plain text available to the caller. Do
not throw an error when the json object is absent.
Signed-off-by: Patrick Tasse patrick.tasse@gmail.com