Issue #254: Constructors of inner classes not resolved properly

- add test case to reproduce #254
- add special case to detect constructors which were declared in the
index file set of the tu

core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/internal/index/tests/IndexCPPBindingResolutionBugsTest.java

@@ -1397,4 +1397,21 @@ public void testTemplateArgumentResolution_450888() throws Exception {
 		ast = workingCopy.getAST(strategy.getIndex(), ITranslationUnit.AST_SKIP_INDEXED_HEADERS);
 		checkBindings(ast);
 	}
+
+	// struct MyClass {
+	//   MyClass();
+	//   struct MyInnerClass;
+	// };
+
+	// struct MyClass::MyInnerClass {
+	// 	MyInnerClass(bool a, bool b) {
+	// 	}
+	// };
+	//
+	// MyClass::MyClass() {
+	// 	new MyInnerClass(true, true);
+	// }
+	public void testIssue_254() throws Exception {
+		checkBindings();
+	}
 }

core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPSemantics.java

@@ -2125,7 +2125,14 @@ public static boolean declaredBefore(Object obj, IASTNode node, boolean indexBas
 				}
 				IASTTranslationUnit tu = node.getTranslationUnit();
 				IIndexFileSet indexFileSet = tu.getIndexFileSet();
-				return (indexFileSet != null && indexFileSet.containsDeclaration(indexBinding));
+				if (indexFileSet != null && indexFileSet.containsDeclaration(indexBinding)) {
+					return true;
+				} else if (indexBinding instanceof ICPPConstructor) {
+					IIndexFileSet astFileSet = tu.getASTFileSet();
+					return astFileSet != null && astFileSet.containsDeclaration(indexBinding);
+				} else {
+					return false;
+				}
 			}
 		}
 		return pointOfDecl < pointOfRef;