Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDBMultiNonStopRunControlTest.testSuspendProcessTwoThreadsRunning[gdbserver] is unstable #119

Closed
jonahgraham opened this issue Oct 26, 2022 · 1 comment · Fixed by #122 or #151
Closed
Labels
releng Release engineering and project management

Comments

@jonahgraham
Copy link
Member

jonahgraham commented Oct 26, 2022

This test regularly fails on Jenkins with this error:

Error Message
Timed out waiting for ServiceEvent: org.eclipse.cdt.dsf.mi.service.command.events.MIStoppedEvent
Stacktrace

java.lang.Exception: Timed out waiting for ServiceEvent: org.eclipse.cdt.dsf.mi.service.command.events.MIStoppedEvent
at org.eclipse.cdt.tests.dsf.gdb.tests.nonstop.GDBMultiNonStopRunControlTest.testSuspendProcessTwoThreadsRunning(GDBMultiNonStopRunControlTest.java:3238)

Standard Output
168,523 "testSuspendProcessTwoThreadsRunning[gdbserver]" requesting gdb with gdbserver. Launched gdb 8.1.1.

@jonahgraham jonahgraham changed the title GDBMultiNonStopRunControlTest.testSuspendProcessTwoThreadsRunning[gdbserver] GDBMultiNonStopRunControlTest.testSuspendProcessTwoThreadsRunning[gdbserver] is unstable Oct 26, 2022
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Oct 27, 2022
The long sleep at the end of each thread is to make sure that
while the test code is waiting for an event the "other" thread
doesn't finish. 3 seconds is not long enough for this.

This is similar to why we need dsf.gdb.tests.timeout.multiplier
for other tests. Especially on the build machines the tests
can run much slower causing the sleep to be insufficient.

Increasing this to 30 seconds doesn't make the test suites
take any longer, when they are all passing.

Fixes eclipse-cdt#119
jonahgraham added a commit that referenced this issue Oct 28, 2022
The long sleep at the end of each thread is to make sure that
while the test code is waiting for an event the "other" thread
doesn't finish. 3 seconds is not long enough for this.

This is similar to why we need dsf.gdb.tests.timeout.multiplier
for other tests. Especially on the build machines the tests
can run much slower causing the sleep to be insufficient.

Increasing this to 30 seconds doesn't make the test suites
take any longer, when they are all passing.

Fixes #119
@jonahgraham jonahgraham reopened this Nov 9, 2022
@jonahgraham
Copy link
Member Author

It failed again on Jenkins

java.lang.Exception: Timed out waiting for ServiceEvent: org.eclipse.cdt.dsf.mi.service.command.events.MIStoppedEvent
	at org.eclipse.cdt.tests.dsf.gdb.tests.nonstop.GDBMultiNonStopRunControlTest.testSuspendProcessTwoThreadsRunning(GDBMultiNonStopRunControlTest.java:3238)

I think this is because although I increased the time the process would stay alive for, I also need to increase how long to wait for.

jonahgraham added a commit to jonahgraham/cdt that referenced this issue Nov 9, 2022
@jonahgraham jonahgraham added the releng Release engineering and project management label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
releng Release engineering and project management
Projects
None yet
1 participant