Fix race condition in multithread test #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The long sleep at the end of each thread is to make sure that while the test code is waiting for an event the "other" thread doesn't finish. 3 seconds is not long enough for this. This is similar to why we need dsf.gdb.tests.timeout.multiplier for other tests. Especially on the build machines the tests can run much slower causing the sleep to be insufficient. Increasing this to 30 seconds doesn't make the test suites take any longer, when they are all passing. Fixes eclipse-cdt#119
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The long sleep at the end of each thread is to make sure that while the test code is waiting for an event the "other" thread doesn't finish. 3 seconds is not long enough for this.
This is similar to why we need dsf.gdb.tests.timeout.multiplier for other tests. Especially on the build machines the tests can run much slower causing the sleep to be insufficient.
Increasing this to 30 seconds doesn't make the test suites take any longer, when they are all passing.
Fixes #119