Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support overriden default editor association in EditorUtility.getEditorID #808

Closed
ghentschke opened this issue May 31, 2024 · 0 comments · Fixed by #809
Closed

Support overriden default editor association in EditorUtility.getEditorID #808

ghentschke opened this issue May 31, 2024 · 0 comments · Fixed by #809
Assignees
@ghentschke

Comments

@ghentschke
Copy link
Contributor

ghentschke commented May 31, 2024 •
edited
Loading

Due to this change #1665 in Eclipse platform, the editor association for external C/C++ files has been broken when the new LSP based C/C++ editor is used (see this cdt-lsp issue #338) and it's set as default editor.

Note: the association is only broken for external files which resides outside of the workspace.

Describe the solution you'd like
This can be fixed by supporting ExternalEditorInput in org.eclipse.cdt.internal.ui.util.EditorUtility

This fixes the cdt-lsp issue #338
@ghentschke ghentschke self-assigned this May 31, 2024
@ghentschke ghentschke changed the title Support overriden default editor association in EditorUtility Support overriden default editor association in EditorUtility.getEditorID May 31, 2024
ghentschke added a commit to ghentschke/cdt-changes that referenced this issue May 31, 2024
@ghentschke
[eclipse-cdt#808] Support overriden default-editor-association in Edi…
592352c 
…torUtility

fixes eclipse-cdt/cdt-lsp#338
@ghentschke ghentschke mentioned this issue May 31, 2024
Merged
jonahgraham pushed a commit that referenced this issue May 31, 2024
@ghentschke
[#808] Support overriden default-editor-association in EditorUtility (#…
9f85daf 
…809)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghentschke ghentschke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#808] Support overriden default-editor-association in EditorUtility ghentschke/cdt-changes
1 participant
@ghentschke