[#808] Support overriden default-editor-association in EditorUtility

[ghentschke]

fixes #808
fixes eclipse-cdt/cdt-lsp#338

[ghentschke]

@jonahgraham can this be part of the next release or am I too late?

[ghentschke]

Note: the cdt-lsp project overrides the default editor associations to ensure that the LSP editor settings on project level will be considered:

Context: As a C/C++-Developer I want to use for my C/C++ projects in my workspace for some projects the old and for some the new LSP-based editor.

[jonahgraham]

I am pretty comfortable with the last minute changes for the CDT-LSP components, but this is pretty core in CDT and we won't have time to respin if there are unintended consequences. Can we leave it for after this release? If you need it in this release, let me know and I will investigate more to see if we can squeeze it in.

[ghentschke]

If you need it in this release, let me know and I will investigate more to see if we can squeeze it in.

I know that this is pretty late but I found this issue in the morning. IMO it's a bigger bug when users want to work with old an new editor in the same workspace (as we do in out product) and we want to update our IDE after this release. So it would be great if you have the time to check this PR.

[jonahgraham]

OK - I will have a look in detail. If I don't see too much concern I will merge this before RC2 build.

[ghentschke]

IMO the risk here is moderate, because this code will be reached only if the input is not an instance of IFileEditorInput and it must be an instanceof ExternalEditorInput which limits the call on non workspace files as well. However, when this code should throw an exception, the previous behavior is ensured (desc is still null).

[jonahgraham]

Can you have a look at

cdt/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/CDebugModelPresentation.java

Lines 232 to 240 in 46d7fb7

	} else if (input instanceof IURIEditorInput) {
	IURIEditorInput uriEditorInput = (IURIEditorInput) input;
	URI uri = uriEditorInput.getURI();
	try {
	IFileStore fileStore = EFS.getStore(uri);
	id = IDE.getEditorDescriptorForFileStore(fileStore, false).getId();
	} catch (CoreException e) {
	// fallback to default case
	}

and let me know if that pattern (which is also used in LSP4E) is more general and applicable here?

Besides that question - I agree this change is low risk and worth getting in.

[ghentschke]

yes, it works as well. Good point!

[jonahgraham]

Thanks @ghentschke - I have merged now.