Simplify the API baseline target #42
Conversation
|
Guys, I submitted the changes as PR. Then I can see how the API baseline is used in the build and you can more easily review this in your local workspace... |
| <unit id="org.eclipse.tm.terminal.connector.cdtserial.feature.feature.group" version="0.0.0"/> | ||
| <unit id="org.eclipse.tm.terminal.connector.remote.feature.feature.group" version="0.0.0"/> | ||
| <unit id="org.eclipse.tm.terminal.feature.feature.group" version="0.0.0"/> | ||
| <repository location="https://download.eclipse.org/tools/cdt/releases/latest"/> |
There was a problem hiding this comment.
Usually we have repository at the top and then we sort locations by repository::location
|
I kind of doubt the test failures can be caused the API baseline change... Now that I look closely, I don't think the baseline target is even used. The actual Maven build uses this which is out of date too: |
merks
force-pushed
the
issue-39-api-baseline
branch
from
8c9049b
to
e5d53cf
Compare
Also simplify the corresponding API baseline targlet in the setup eclipse-cdt#39
merks
force-pushed
the
issue-39-api-baseline
branch
from
e5d53cf
to
aab5f74
Compare
|
Given the cdt-baseline.target is not used in the build, but rather is only used for a manual setup, reducing maintenance effort would definitely be a good thing... |
That is the compare and replace repo. Separate from api baseline. As mentioned in the other comment I just made that eclipse-cdt/cdt-infra#59 needs to be done for next version and currently main hasn’t been prepped for post 10.7 yet. BTW main branch will be 11.0 next, that is a major release of CDT is upcoming. |
|
I’m glad that you (Ed) are simplifying and that Alexander has time to review these changes. I will happily review anything left to review later. |
Also simplify the corresponding API baseline targlet in the setup
#39