Remove DiscoveredPathContainerPage #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class DiscoveredPathContainerPage used a number of APIs in the Eclipse Platform [removed](eclipse-platform/eclipse.platform.ui#1563) in [Eclipse 4.31 release](https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/81e406456ffae2f82fe0bb244adfdc4121c9e463/eclipse.platform.common/bundles/org.eclipse.platform.doc.isv/porting/removals.html#L595). This class, while API, has not be used, nor usable since the CDT 4 release as it was only for CDT 3.x style projects. The class had been deprecated since 2010. To mitigate against the possibility that someone may have a dependency on this old class the minor version has been bumped so that version range can have `,8.3)` as their upper version. Fixes eclipse-cdt#700
|
@eclipse-cdt/tools-cdt-committers can a committer review this and provide a second approval to removing this class. |
|
+2 |
ruspl-afed
reviewed
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class DiscoveredPathContainerPage used a number of APIs in the Eclipse Platform removed in Eclipse 4.31 release. This class, while API, has not be used, nor usable since the CDT 4 release as it was only for CDT 3.x style projects. The class had been deprecated since 2010.
To mitigate against the possibility that someone may have a dependency on this old class the minor version has been bumped so that version range can have
,8.3)as their upper version.Fixes #700