delete WorkbenchCommandSupport "API is scheduled for deletion"

[jukzi]

fix "overriding a synchronized method without being synchronized" and several deprecation warnings

[jukzi]

@vogella is it OK straight delete an unused API marked for deletion at this stage?

[github-actions]

Test Results

   918 files  ± 0     918 suites  ±0   1h 12m 51s ⏱️ + 21m 26s
 7 433 tests  -  6   7 283 ✅  -  4  150 💤  - 2  0 ❌ ±0 
23 448 runs   - 18  22 946 ✅  - 12  502 💤  - 6  0 ❌ ±0 

Results for commit dfccd1d. ± Comparison against base commit 04a9884.

This pull request removes 6 tests.

org.eclipse.ui.tests.commands.Bug66182Test ‑ Unknown test
org.eclipse.ui.tests.commands.Bug70503Test ‑ testHandlerChangeCausesUpdate
org.eclipse.ui.tests.commands.Bug74982Test ‑ testSelectAllHandlerSendsSelectionEvent
org.eclipse.ui.tests.commands.Bug74990Test ‑ testPartIdSubmission
org.eclipse.ui.tests.commands.Bug87856Test ‑ testHandlerLeak
org.eclipse.ui.tests.keys.Bug36420Test ‑ Unknown test

♻️ This comment has been updated with latest results.

[vogella]

@vogella is it OK straight delete an unused API marked for deletion at this stage?

The process is described here: https://github.com/eclipse-platform/eclipse.platform/blob/master/docs/ApiRemovalProcess.md I don't see the annotation in your commit so you need to check (and potentially update) https://help.eclipse.org/latest/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Fporting%2Fremovals.html if the freeze period for this API is already gone.

[jukzi]

the code deleted is annotated with ancient

	 * @deprecated Please use {@link IServiceLocator#getService(Class)} instead.
	 *             This API is scheduled for deletion, see Bug 431177 for details
	 * @noreference IWorkbenchCommandSupport is scheduled for deletion.

[vogella]

Yes, this API can be deleted, I marked that for deletion a long time ago. Please move also the entry in https://help.eclipse.org/latest/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Fporting%2Fremovals.html to the deleted API section.

[jukzi]

Please move also the entry

eclipse-platform/eclipse.platform.releng.aggregator#1748

[jukzi]

how to get rid of this errors?

09:25:24.894 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.5-SNAPSHOT:verify (verify) on project org.eclipse.ui.workbench: There are API errors:
09:25:24.894 [ERROR] META-INF/MANIFEST.MF:0 The type org.eclipse.ui.commands.AbstractHandler has been removed from org.eclipse.ui.workbench_3.131.100
...
09:25:24.894 [ERROR] META-INF/MANIFEST.MF:0 The type org.eclipse.ui.commands.Priority has been removed from org.eclipse.ui.workbench_3.131.100
09:25:24.894 [ERROR] META-INF/MANIFEST.MF:5 The major version should be incremented in version 3.131.100, since API breakage occurred since version 3.131.0

[laeubi]

how to get rid of this errors?

Add proper compatibility filter or increment the major version ...

[vogella]

Add proper compatibility filter or increment the major version ...

Filter. Major version increase for planned API deletion was tried once (by me) and caused a storm of complaints. Therefore, the PMC decided that or planned API deletions we only increase the minor version and use API filter (quickfix) to hide the warnings from the API tools.

[jukzi]

I added filter with quick fix. The error on mac is unrelated. The "new ecj warnings" are false positives (added API warnings).
Can i submit?

[laeubi]

The "new ecj warnings" are false positives (added API warnings). Can i submit?

They are not "false positives" pleas either fix API warnings or suppress them as well.

[jukzi]

They are not "false positives" pleas either fix API warnings or suppress them as well.

Which so called "new" warnings exactly do you think is related to this PR?
https://ci.eclipse.org/platform/job/eclipse.platform.ui/job/PR-1563/6/eclipse/new/