Add whitespace to the is Http check regex pattern #1150
Conversation
|
Click here to review and test in web IDE: |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1150 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1150", name: che-dashboard}]}}]" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1150 +/- ##
==========================================
+ Coverage 89.46% 89.60% +0.14%
==========================================
Files 415 415
Lines 42461 42461
Branches 2831 2832 +1
==========================================
+ Hits 37987 38049 +62
+ Misses 4443 4385 -58
+ Partials 31 27 -4 ☔ View full report in Codecov by Sentry. |
| @@ -54,7 +54,7 @@ export class FactoryLocationAdapter implements FactoryLocation { | |||
| } | |||
|
|
|||
| public static isHttpLocation(href: string): boolean { | |||
| return /^(https?:\/\/.)[-a-zA-Z0-9@:%._+~#=]{2,}\b([-a-zA-Z0-9@:%_+.~#?&/={},]*)$/.test(href); | |||
| return /^(https?:\/\/.)[-a-zA-Z0-9@:%._+~#=]{2,}\b([-a-zA-Z0-9@:%_+.~#?&/={}, ]*)$/.test(href); | |||
There was a problem hiding this comment.
@vinokurig could you please add a unit test for that ?
|
Verified on Eclipse Che with |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, artaleks9, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1150 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1150", name: che-dashboard}]}}]" |
|
Build 3.16 :: dashboard_3.x/511: Console, Changes, Git Data |
|
Build 3.16 :: sync-to-downstream_3.x/7300: Console, Changes, Git Data |
|
Build 3.16 :: push-latest-container-to-quay_3.x/4776: Console, Changes, Git Data |
|
Build 3.16 :: get-sources-rhpkg-container-build_3.x/7279: dashboard : 3.x :: Build 62856900 : quay.io/devspaces/dashboard-rhel8:3.16-9 |
|
Build 3.16 :: update-digests_3.x/7126: Console, Changes, Git Data |
|
Build 3.16 :: dashboard_3.x/511: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7300 triggered |
|
Build 3.16 :: operator-bundle_3.x/3353: Console, Changes, Git Data |
|
Build 3.16 :: sync-to-downstream_3.x/7302: Console, Changes, Git Data |
|
Build 3.16 :: push-latest-container-to-quay_3.x/4778: Console, Changes, Git Data |
|
Build 3.16 :: copyIIBsToQuay/2712: Console, Changes, Git Data |
|
Build 3.16 :: sync-to-downstream_3.x/7302: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7281 triggered; /job/DS_CI/job/dsc_3.x triggered; |
|
Build 3.16 :: operator-bundle_3.x/3353: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7302 triggered |
|
Build 3.16 :: dsc_3.x/1950: Console, Changes, Git Data |
|
Build 3.16 :: update-digests_3.x/7126: Detected new images: rebuild operator-bundle |
|
Build 3.16 :: dsc_3.x/1950: 3.16.0-CI |
What does this PR do?
Add whitespace to the
isHttpLocationcheck regex pattern.What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-6790
Is it tested? How?
Try to start a workspace from a repository url with whitespace, e.g.
https://vinokurig@dev.azure.com/vinokurig/public/_git/re poRelease Notes
Docs PR