-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deleting workspace flow #259
Conversation
Codecov Report
@@ Coverage Diff @@
## main #259 +/- ##
==========================================
- Coverage 49.94% 49.91% -0.03%
==========================================
Files 140 140
Lines 5246 5249 +3
Branches 846 848 +2
==========================================
Hits 2620 2620
- Misses 2385 2388 +3
Partials 241 241
Continue to review full report at Codecov.
|
Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-259 |
✅ E2E dashboard tests succeed 🎉 See Details
Tested with Eclipse Che on K8S (minikube v1.1.1)
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't say anything about changes but I tested it and it works just fine.
@olexii4 please rewrite commit messages to satisfy Semantic Pull Request check |
Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-259 |
❌ E2E dashboard tests failed ❗ See Details
Tested with Eclipse Che on K8S (minikube v1.1.1)
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
[dashboard-ci-test] |
✅ E2E dashboard tests succeed 🎉 See Details
Tested with Eclipse Che on K8S (minikube v1.1.1)
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Signed-off-by: Oleksii Orel <oorel@redhat.com>
…m Workspace' page Signed-off-by: Oleksii Orel <oorel@redhat.com>
Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-259 |
✅ E2E dashboard tests succeed 🎉 See Details
Tested with Eclipse Che on K8S (minikube v1.1.1)
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
it should be cherry-picked to 7.31.x to faster deliver fix to users (like Che Dev Cluster) |
Signed-off-by: Oleksii Orel oorel@redhat.com
What does this PR do?
This PR fixed several bugs some improvement:
What issues does this PR fix or reference?
fixes eclipse-che/che#19833