Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deleting workspace flow #259

Merged
merged 5 commits into from
Jun 2, 2021
Merged

Fix deleting workspace flow #259

merged 5 commits into from
Jun 2, 2021

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jun 1, 2021

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

This PR fixed several bugs some improvement:

  • Fix the create state helper function. Add a test.
  • Fix handing 'enter' button when using invalid URL.
  • Added handling 'enter' button for 'Load Devfile' on 'Custom Workspace' page.

What issues does this PR fix or reference?

fixes eclipse-che/che#19833

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #259 (eff0839) into main (01a90b1) will decrease coverage by 0.02%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   49.94%   49.91%   -0.03%     
==========================================
  Files         140      140              
  Lines        5246     5249       +3     
  Branches      846      848       +2     
==========================================
  Hits         2620     2620              
- Misses       2385     2388       +3     
  Partials      241      241              
Impacted Files Coverage Δ
...kspaceTab/DevfileSelector/DevfileLocationInput.tsx 84.61% <0.00%> (-11.04%) ⬇️
...tStartedTab/ImportFromGit/GitRepoLocationInput.tsx 44.00% <0.00%> (-1.84%) ⬇️
src/store/helpers.ts 100.00% <100.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01a90b1...eff0839. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-259

@che-bot
Copy link
Contributor

che-bot commented Jun 1, 2021

✅ E2E dashboard tests succeed 🎉

See Details

Tested with Eclipse Che on K8S (minikube v1.1.1)

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say anything about changes but I tested it and it works just fine.

@sleshchenko
Copy link
Member

@olexii4 please rewrite commit messages to satisfy Semantic Pull Request check

@github-actions
Copy link

github-actions bot commented Jun 2, 2021

Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-259

@che-bot
Copy link
Contributor

che-bot commented Jun 2, 2021

❌ E2E dashboard tests failed ❗

See Details

Tested with Eclipse Che on K8S (minikube v1.1.1)

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@olexii4
Copy link
Contributor Author

olexii4 commented Jun 2, 2021

[dashboard-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Jun 2, 2021

✅ E2E dashboard tests succeed 🎉

See Details

Tested with Eclipse Che on K8S (minikube v1.1.1)

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

Signed-off-by: Oleksii Orel <oorel@redhat.com>
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Signed-off-by: Oleksii Orel <oorel@redhat.com>
…m Workspace' page

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@github-actions
Copy link

github-actions bot commented Jun 2, 2021

Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-259

@olexii4 olexii4 merged commit 0394221 into main Jun 2, 2021
@olexii4 olexii4 deleted the CHE-19833 branch June 2, 2021 13:50
@che-bot
Copy link
Contributor

che-bot commented Jun 2, 2021

✅ E2E dashboard tests succeed 🎉

See Details

Tested with Eclipse Che on K8S (minikube v1.1.1)

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@sleshchenko
Copy link
Member

it should be cherry-picked to 7.31.x to faster deliver fix to users (like Che Dev Cluster)

@che-bot che-bot added this to the 7.32 milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants