Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a nodejs stack #15

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Add a nodejs stack #15

merged 1 commit into from
Jun 19, 2019

Conversation

l0rd
Copy link
Contributor

@l0rd l0rd commented Jun 18, 2019

What does this PR do?

Add a new nodjes stack with an hello-world express web application

What issues does this PR fix or reference?

eclipse-che/che#12620

@l0rd l0rd changed the title What does this PR do? ===================== Add a nodejs stack Jun 18, 2019
@l0rd l0rd requested a review from sleshchenko June 18, 2019 19:21
@sleshchenko
Copy link
Member

@l0rd If you plan to add more devfiles, please let us know here eclipse-che/che#13529 (comment)

@ibuziuk
Copy link
Member

ibuziuk commented Jun 19, 2019

Works like a charm on che.openshift.io -
image

I have added this devfile into the list of replacement for getting-started - https://github.com/ibuziuk/my-che-devfiles/tree/master/nodejs-quickstart

Also, once eclipse-che/che#13561 we could add supportArbitraryUser: 'true' (not sure but I think that /etc/passwd should be writable)

@l0rd l0rd merged commit 4d140f3 into eclipse-che:master Jun 19, 2019
@l0rd l0rd deleted the new-nodejs-stack branch June 19, 2019 11:14
@l0rd
Copy link
Contributor Author

l0rd commented Jun 19, 2019

@sleshchenko @metlos I've created this PR on the nodejs stack because it was assigned to me (c.f. #1620) and #13529 was more about the sample rather than the stack itself. But I am happy to let you work on the rest. I have just assigned the react stack to myself because I had started working on it.

monaka added a commit that referenced this pull request Feb 1, 2020
Ohrimenko1988 added a commit that referenced this pull request May 21, 2020
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
Ohrimenko1988 added a commit that referenced this pull request Jun 1, 2020
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
sparkoo pushed a commit to sparkoo/che-devfile-registry that referenced this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants