-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix caching of images when multiple images specified #150
Conversation
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
I added a commit to resolve another issue I ran into while testing: Images can be passed with query parameters, e.g. https://raw.githubusercontent.com/redhat-developer/codeready-workspaces/master/dependencies/che-devfile-registry/images/type-java.svg?sanitize=true The devfile registry currently will save images with filename |
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
* Fix caching of images when multiple images specified * Remove query parameters from filename when saving devfile icon Signed-off-by: Angel Misevski <amisevsk@redhat.com>
What does this PR do?
Fix bug reading list of images specified in meta.yamls, where more than one unique URL would cause caching script to fail.
What issues does this PR fix or reference?
eclipse-che/che#15293