Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache_images.sh will be failed in case the registry have multiple icons. #15293

Closed
1 of 3 tasks
monaka opened this issue Nov 25, 2019 · 2 comments
Closed
1 of 3 tasks

cache_images.sh will be failed in case the registry have multiple icons. #15293

monaka opened this issue Nov 25, 2019 · 2 comments
Labels
area/devfile-registry kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
7.6.0

Comments

@monaka
Copy link
Member

monaka commented Nov 25, 2019

Describe the bug

cache_images.sh will be failed when meta.yaml by third party was added.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Add new meta.yaml with icon: not pointing https://www.eclipse.org/che/images/logo-eclipseche.svg
  2. Build image.

The build failure of my forked devfile-registry.
https://dev.azure.com/pizzafactory/camino/_build/results?buildId=1476&view=logs&jobId=12f1170f-54f2-53f3-20dd-22fc7dff55f9&taskId=f8ed7bd8-2a7f-56f6-9385-7fc29a8b5b7b&lineStart=517&lineEnd=518&colStart=1&colEnd=1

Expected behavior

Finishing the build with success.

Additional context

I've already fixed this issue. I'm going to send PR.
@monaka monaka added kind/bug Outline of a bug - must adhere to the bug report template. area/devfile-registry labels Nov 25, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 25, 2019
monaka added a commit to eclipse-che/che-devfile-registry that referenced this issue Nov 25, 2019
@monaka
Remove quotes.
71fa5a3 
See eclipse-che/che#15293.

Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
@monaka monaka mentioned this issue Nov 25, 2019
Closed
@ibuziuk ibuziuk added team/osio severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 25, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Nov 25, 2019

@amisevsk could you please take a look and comment?

@amisevsk amisevsk mentioned this issue Nov 25, 2019
Merged
@ibuziuk ibuziuk added this to the 7.6.0 milestone Nov 27, 2019
@amisevsk amisevsk mentioned this issue Dec 4, 2019
Merged
@amisevsk
Copy link
Contributor

amisevsk commented Dec 4, 2019

Fixed for 7.6.0 and 7.3.3

@amisevsk amisevsk closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/devfile-registry kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
7.6.0
Development

Successfully merging a pull request may close this issue.

Remove quotes. eclipse-che/che-devfile-registry
4 participants
@monaka @ibuziuk @amisevsk @che-bot