Set up CI for repo using github actions #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amisevsk
requested review from
ibuziuk,
l0rd,
nickboldt,
rhopp,
skabashnyuk and
vparfonov
as code owners
nickboldt
reviewed
Dec 17, 2019
|
|
||
| jobs: | ||
| shellcheck: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
could we do this on RHEL8 instead?
There was a problem hiding this comment.
It's a GitHub thing, your options are mac, windows, or ubuntu 🙁
I could look into updating it to run in a rhel docker container, but this is my first go at configuring GitHub actions.
There was a problem hiding this comment.
+1 for this PR, +2 if you want to do a followup.
nickboldt
approved these changes
Dec 17, 2019
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
force-pushed
the
add-actions-ci
branch
from
4f6852c
to
a125090
Compare
|
What's left on this issue is adding branch protections in the settings tab on the devfile registry; I don't have access to this so someone else will have to do it. |
|
Just checked: don't have perms to view https://github.com/eclipse/che-devfile-registry/settings either. Maybe @l0rd or @benoitf have permission? |
sparkoo
pushed a commit
to sparkoo/che-devfile-registry
that referenced
this pull request
Dec 4, 2020
* Update omnisharp-theia-plugin to 0.0.2 Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com> * Fix firstPublicationDate in latest omnisharp plugin Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add CI for pull requests that
To test, I added it to my fork
What issues does this PR fix or reference?
Fixes eclipse-che/che#14867