Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AngularJS devfile along with sample project #19

Merged
merged 5 commits into from
Jun 25, 2019

Conversation

sleshchenko
Copy link
Member

@sleshchenko sleshchenko commented Jun 21, 2019

What does this PR do?

Add AngularJS devfile along with sample project.

Initially, there was test command but I removed this since it requires CHROME BIN and maybe this is not even enough to run tests inside a container. I'll create a separate issue to improve this devfile after merging this PR.
Screenshot_20190624_181153

What issues does this PR fix or reference?

eclipse-che/che#13529

Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
@sleshchenko sleshchenko requested review from slemeur and l0rd June 24, 2019 15:26
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
@sleshchenko sleshchenko marked this pull request as ready for review June 24, 2019 15:28
@sleshchenko sleshchenko merged commit e47400f into eclipse-che:master Jun 25, 2019
@sleshchenko sleshchenko deleted the angular branch June 25, 2019 13:56
monaka referenced this pull request in PizzaFactory/che-devfile-registry Jun 28, 2019
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
monaka added a commit that referenced this pull request Feb 1, 2020
Ohrimenko1988 added a commit that referenced this pull request May 21, 2020
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
Ohrimenko1988 added a commit that referenced this pull request Jun 1, 2020
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
sparkoo pushed a commit to sparkoo/che-devfile-registry that referenced this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants