-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NodeJS stack with react realworld app #29
Conversation
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
type: dockerimage | ||
alias: nodejs | ||
# system limit for number of file watchers reached with | ||
# image: registry.access.redhat.com/ubi8/nodejs-10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this issue logged/tracked somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhopp
No. Should issue be created in eclipse/che repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a couple of minor comments but otherwise LGTM
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
* Add NodeJS stack with react realworld app Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Add `fetch-depth: 0` to actions/checkout@v2.
Add che-machine-exec plugin.
Signed-off-by: Anatoliy Bazko abazko@redhat.com
What does this PR do?
Adds NodeJS stack with the react realworld example [1]
Issues
It is not possible to use
registry.access.redhat.com/ubi8/nodejs-10
image due to errorsystem limit for number of file watchers reached
when server starts (npm start
).API_ROOT
[2] can't be modified due to issue [3]What issues does this PR fix or reference?
eclipse-che/che#13529
[1] https://github.com/gothinkster/react-redux-realworld-example-app
[2] https://github.com/gothinkster/react-redux-realworld-example-app/blob/master/src/agent.js#L6
[3] gothinkster/react-redux-realworld-example-app#134