Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NodeJS stack with react realworld app #29

Merged
merged 3 commits into from
Jul 9, 2019
Merged

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jul 6, 2019

Signed-off-by: Anatoliy Bazko abazko@redhat.com

What does this PR do?

Adds NodeJS stack with the react realworld example [1]

Issues

  1. It is not possible to use registry.access.redhat.com/ubi8/nodejs-10 image due to error system limit for number of file watchers reached when server starts (npm start).

  2. API_ROOT [2] can't be modified due to issue [3]

What issues does this PR fix or reference?

eclipse-che/che#13529

[1] https://github.com/gothinkster/react-redux-realworld-example-app
[2] https://github.com/gothinkster/react-redux-realworld-example-app/blob/master/src/agent.js#L6
[3] gothinkster/react-redux-realworld-example-app#134

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
type: dockerimage
alias: nodejs
# system limit for number of file watchers reached with
# image: registry.access.redhat.com/ubi8/nodejs-10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this issue logged/tracked somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhopp
No. Should issue be created in eclipse/che repo?

Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a couple of minor comments but otherwise LGTM

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@tolusha tolusha merged commit 916fee5 into master Jul 9, 2019
@tolusha tolusha deleted the ab/nodejs-react branch July 9, 2019 00:00
nickboldt pushed a commit to nickboldt/che-devfile-registry that referenced this pull request Aug 9, 2019
* Add NodeJS stack with react realworld app

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
monaka added a commit that referenced this pull request Mar 14, 2020
Add `fetch-depth: 0` to actions/checkout@v2.
Ohrimenko1988 added a commit that referenced this pull request Jun 3, 2020
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
sparkoo pushed a commit to sparkoo/che-devfile-registry that referenced this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants