Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Devfiles which are based on Che 7 Stacks #3

Merged
merged 8 commits into from
May 27, 2019

Conversation

sleshchenko
Copy link
Member

@sleshchenko sleshchenko commented May 22, 2019

What does this PR do?

This PR adds Devfiles which are based on Che 7 Stacks listed in eclipse-che/che#12620

Also, devfiles structure is changed and now a registry contains two files meta.yaml (with displayName, description, icon) and devfile.yaml.

devfile-registry

What issues does this PR fix or reference?

eclipse-che/che#13353

Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
…oned by Che Server

Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
@l0rd
Copy link
Contributor

l0rd commented May 26, 2019

@sleshchenko as a consequence of eclipse-che/che#13414 we should now use latest as versions for plugins.

Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
@sleshchenko sleshchenko marked this pull request as ready for review May 27, 2019 10:34
@sleshchenko
Copy link
Member Author

@l0rd

@sleshchenko as a consequence of eclipse-che/che#13414 we should now use latest as versions for plugins.

PR you mentioned is not merged yet. Stack description declares its components version, like (Java Stack with OpenJDK 11 and Gradle 5.2.1), are you sure that plugins should use latest since java version is fixed? Is the latest java plugin compatible with OpenJDK 11?
BTW Are you OK to create a separate issue for that?

@l0rd
Copy link
Contributor

l0rd commented May 27, 2019

@sleshchenko yes I will create a separate issue so we can discuss that. No need to include that in this PR.

@sleshchenko sleshchenko merged commit df22730 into eclipse-che:master May 27, 2019
@sleshchenko sleshchenko deleted the initialDevfiles branch May 27, 2019 13:04
@l0rd
Copy link
Contributor

l0rd commented May 27, 2019

FYI eclipse-che/che#13426

@sleshchenko sleshchenko mentioned this pull request May 27, 2019
@sleshchenko sleshchenko self-assigned this Jun 10, 2019
@nickboldt nickboldt mentioned this pull request Jan 6, 2020
Ohrimenko1988 added a commit that referenced this pull request May 13, 2020
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
Ohrimenko1988 added a commit that referenced this pull request May 29, 2020
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
sparkoo pushed a commit to sparkoo/che-devfile-registry that referenced this pull request Dec 4, 2020
Added OpenShift deployment configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants