This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
Add default kubernetes labels #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
tolusha
requested review from
benoitf,
ericwill,
JPinkney,
sunix,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
79 tasks
ericwill
approved these changes
Jan 11, 2021
ericwill
approved these changes
Jan 11, 2021
sleshchenko
reviewed
Jan 11, 2021
| name: che-devfile-registry | ||
| labels: | ||
| app: che |
There was a problem hiding this comment.
Why do we need app? Should not it be replaced with app.kubernetes.io/name: che?
There was a problem hiding this comment.
We use these labels on chectl side to find a corresponding deployment.
| spec: | ||
| replicas: 1 | ||
| revisionHistoryLimit: 2 | ||
| selector: | ||
| matchLabels: | ||
| app: che-devfile-registry | ||
| app: che | ||
| component: devfile-registry |
There was a problem hiding this comment.
Should not it be replaced with app.kubernetes.io/component from https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/ ?
There was a problem hiding this comment.
We keep those labels in che-operator since selector field is immutable.
So I decided to keep the same labels here as well.
app: che
component: devfile-registry
54 tasks
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
|
@ibuziuk |
57 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
What issues does this PR fix or reference?
eclipse-che/che#18357
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.