This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
chore: don't generate theia resources; remove sidecars; add devfile.yaml to work with the registry #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
|
Click here to review and test in web IDE: |
svor
changed the title
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
svor
changed the title
nickboldt
reviewed
Mar 30, 2023
nickboldt
reviewed
Mar 30, 2023
nickboldt
reviewed
Mar 30, 2023
nickboldt
reviewed
Mar 30, 2023
nickboldt
reviewed
Mar 30, 2023
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
Co-authored-by: Nick Boldt <nboldt@redhat.com>
nickboldt
approved these changes
Mar 30, 2023
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Screenshot/screencast of this PR
I've used a devfile.yaml provided by the current changes to test if the registry works. For this I prepared OS instance with Che, added build capabilities to the cluster and:
Build registry by executing 1. Build and Publish a Custom Devfile Registry command:
Executed a command to use resulted image: 2. Configure Che to use the Custom Devfile Registry
Checked che-devfile-registry pod:
What issues does this PR fix or reference?
eclipse-che/che#22091
How to test this PR?
htdocs/devfiles/stack/folders, they should contain generated devworkspaces only for che-code and che-idea editorsPR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.