Add the devfile to work with c/c++ stack

[tolusha]

What does this PR do?

It adds the devfile to work with c/c++ stack

What issues does this PR fix or reference?

eclipse-che/che#13698

[ibuziuk]

@tolusha am I correct that this PR is meant to be merged after GA ?

[tolusha]

@ibuziuk yes, you are right. It is for 7.1.0

[tolusha]

@l0rd @amisevsk
Could some approve the PR?

[amisevsk]

I can't seem to get this workspace started on latest nightlies.

On OpenShift, the cpp-plugin container enters a crash loop, terminated with exit code 1.

[amisevsk]

Also worth noting that this devfile is incompatible with 7.0.0 I believe, since it depends on eclipse-che/che#14174 cc: @ibuziuk

[amisevsk]

Logs from the failing container

Starting the deployer with the list of resolvers [ LocalDirectoryPluginDeployerResolver {},
--
  | GithubPluginDeployerResolver { unpackedFolder: '/tmp/github-remote' },
  | HttpPluginDeployerResolver { unpackedFolder: '/tmp/http-remote' },
  | VsCodePluginDeployerResolver { vscodeExtensionsFolder: '/tmp/vscode-extension-marketplace' } ]
  | Theia Endpoint 19/pid listening on port 2503
  | Found the list of default plugins ID on env: undefined
  | Found the list of plugins ID on env: local-dir:///plugins/sidecars/che_incubator_cpptools_latest
  | Found the list of default plugins ID from CLI: undefined
  | unzipping the plugin ProxyPluginDeployerEntry {
  | deployer:
  | PluginVsCodeFileHandler { unpackedFolder: '/tmp/vscode-unpacked' },
  | delegate:
  | PluginDeployerEntryImpl {
  | originId:
  | 'local-dir:///plugins/sidecars/che_incubator_cpptools_latest',
  | pluginId:
  | 'che-incubator.cpptools.latest.hnoaqagcwz.cdt-vscode-0.0.7.vsix',
  | map: Map {},
  | changes: [],
  | acceptedTypes: [],
  | currentPath:
  | '/plugins/sidecars/che_incubator_cpptools_latest/che-incubator.cpptools.latest.hnoaqagcwz.cdt-vscode-0.0.7.vsix',
  | initPath:
  | '/plugins/sidecars/che_incubator_cpptools_latest/che-incubator.cpptools.latest.hnoaqagcwz.cdt-vscode-0.0.7.vsix',
  | resolved: true,
  | resolvedByName: 'LocalDirectoryPluginDeployerResolver' },
  | deployerName: 'PluginVsCodeFileHandler' }
  | unzipping the plugin ProxyPluginDeployerEntry {
  | deployer:
  | PluginVsCodeFileHandler { unpackedFolder: '/tmp/vscode-unpacked' },
  | delegate:
  | PluginDeployerEntryImpl {
  | originId:
  | 'local-dir:///plugins/sidecars/che_incubator_cpptools_latest',
  | pluginId:
  | 'che-incubator.cpptools.latest.hwcyhssqiw.llvm-vs-code-extensions.vscode-clangd-0.0.16.vsix',
  | map: Map {},
  | changes: [],
  | acceptedTypes: [],
  | currentPath:
  | '/plugins/sidecars/che_incubator_cpptools_latest/che-incubator.cpptools.latest.hwcyhssqiw.llvm-vs-code-extensions.vscode-clangd-0.0.16.vsix',
  | initPath:
  | '/plugins/sidecars/che_incubator_cpptools_latest/che-incubator.cpptools.latest.hwcyhssqiw.llvm-vs-code-extensions.vscode-clangd-0.0.16.vsix',
  | resolved: true,
  | resolvedByName: 'LocalDirectoryPluginDeployerResolver' },
  | deployerName: 'PluginVsCodeFileHandler' }
  | unzipping the plugin ProxyPluginDeployerEntry {
  | deployer:
  | PluginVsCodeFileHandler { unpackedFolder: '/tmp/vscode-unpacked' },
  | delegate:
  | PluginDeployerEntryImpl {
  | originId:
  | 'local-dir:///plugins/sidecars/che_incubator_cpptools_latest',
  | pluginId:
  | 'che-incubator.cpptools.latest.hzgonxjjgp.cdt-gdb-vscode-0.0.90.vsix',
  | map: Map {},
  | changes: [],
  | acceptedTypes: [],
  | currentPath:
  | '/plugins/sidecars/che_incubator_cpptools_latest/che-incubator.cpptools.latest.hzgonxjjgp.cdt-gdb-vscode-0.0.90.vsix',
  | initPath:
  | '/plugins/sidecars/che_incubator_cpptools_latest/che-incubator.cpptools.latest.hzgonxjjgp.cdt-gdb-vscode-0.0.90.vsix',
  | resolved: true,
  | resolvedByName: 'LocalDirectoryPluginDeployerResolver' },
  | deployerName: 'PluginVsCodeFileHandler' }
  | PluginTheiaDirectoryHandler: accepting plugin with path /tmp/vscode-unpacked/che-incubator.cpptools.latest.hnoaqagcwz.cdt-vscode-0.0.7.vsix
  | Resolving "che-incubator.cpptools.latest.hnoaqagcwz.cdt-vscode-0.0.7.vsix" as a VS Code extension...
  | Resolved "che-incubator.cpptools.latest.hnoaqagcwz.cdt-vscode-0.0.7.vsix" to a VS Code extension "cdt-vscode@0.0.7" with engines: { vscode: '^1.30.0' }
  | PluginTheiaDirectoryHandler: accepting plugin with path /tmp/vscode-unpacked/che-incubator.cpptools.latest.hwcyhssqiw.llvm-vs-code-extensions.vscode-clangd-0.0.16.vsix
  | Resolving "che-incubator.cpptools.latest.hwcyhssqiw.llvm-vs-code-extensions.vscode-clangd-0.0.16.vsix" as a VS Code extension...
  | Resolved "che-incubator.cpptools.latest.hwcyhssqiw.llvm-vs-code-extensions.vscode-clangd-0.0.16.vsix" to a VS Code extension "vscode-clangd@0.0.16" with engines: { vscode: '^1.36.0' }
  | PluginTheiaDirectoryHandler: accepting plugin with path /tmp/vscode-unpacked/che-incubator.cpptools.latest.hzgonxjjgp.cdt-gdb-vscode-0.0.90.vsix
  | Resolving "che-incubator.cpptools.latest.hzgonxjjgp.cdt-gdb-vscode-0.0.90.vsix" as a VS Code extension...
  | Resolved "che-incubator.cpptools.latest.hzgonxjjgp.cdt-gdb-vscode-0.0.90.vsix" to a VS Code extension "cdt-gdb-vscode@0.0.90" with engines: { vscode: '^1.26.0' }
  | /home/theia/node_modules/@theia/plugin-ext-vscode/lib/node/plugin-vscode-resolver.js:129
  | asset = extension.versions[0].files.filter(function (f) { return f.assetType === 'Microsoft.VisualStudio.Services.VSIXPackage'; })[0];
  | ^
  |  
  | TypeError: Cannot read property 'versions' of undefined
  | at Request._callback (/home/theia/node_modules/@theia/plugin-ext-vscode/lib/node/plugin-vscode-resolver.js:129:55)
  | at Request.self.callback (/home/theia/node_modules/request/request.js:185:22)
  | at Request.emit (events.js:198:13)
  | at Request.<anonymous> (/home/theia/node_modules/request/request.js:1161:10)
  | at Request.emit (events.js:198:13)
  | at IncomingMessage.<anonymous> (/home/theia/node_modules/request/request.js:1083:12)
  | at Object.onceWrapper (events.js:286:20)
  | at IncomingMessage.emit (events.js:203:15)
  | at endReadableNT (_stream_readable.js:1145:12)
  | at process._tickCallback (internal/process/next_tick.js:63:19)

[tolusha]

@amisevsk
Thank you for validation

eclipse-theia/theia#5993

[amisevsk]

Tested again on current nightlies:

The workspace starts up no problem and I can execute build.

However, I get an error after opening the .cpp file:

Error starting C/C++ language server. Please make sure 'clangd' is installed on your system. You can refer to the clangd page for instructions.

Additionally, I'm against merging this PR using a community image (registry.centos.org/centos/devtoolset-7-toolchain-centos7) as it has most of the problems the arbitrary user id patch was made to resolve. The steps to adding a patched image are

1. Add a line like che-cpp-centos registry.centos.org/centos/devtoolset-7-toolchain-centos7 to base_images
2. Test that builds okay ./arbitrary-users-patch/build_images.sh
3. Create quay.io repo for the new image https://quay.io/organization/eclipse/
4. Update devfile to use this new image.

[tolusha]

Remaining issue:

Error starting C/C++ language server. Please make sure 'clangd' is installed on your system. You can refer to the clangd page for instructions.

[nickboldt]

Per @amisevsk 's comment #73 (review) I've created this PR to add the cpp stack:

#100

[nickboldt]

Per @amisevsk 's comment #73 (review) I've created this PR to add the cpp stack:

#100

[tolusha]

@nickboldt
I see you've added
che-cpp-rhel7 registry.access.redhat.com/devtools/llvm-toolset-rhel7

Is it supposed to be used in c++ stack instead of che-cpp7-centos ?
What are the benefits?

[nickboldt]

Is it supposed to be used in c++ stack instead of che-cpp7-centos ?

Yes

What are the benefits?

1. same upstream and downstream, no need to fork dockerfile for community/centos and product/rhel: less work in downstream

2. same bits, effectively, since no one will be trying to update the container and need to worry about subscriptions/entitlements (which is the real value for centos over rhel, but now that we have UBI and it's just as free as centos, there's no need to use centos): we use the free supported RHEL instead of the free community-built RHEL

3. CVE fixes come faster in UBI than in CentOS.

[nickboldt]

switch to use che-cpp-rhel7

[skabashnyuk]

is this image available publicly?

[tolusha]

It will be available once I merge the PR
It is available

[amisevsk]

Is it supposed to be used in c++ stack instead of che-cpp7-centos ?

This new image is meant to resolve #73 (comment) (it includes clang). RHEL was chosen because it's @nickboldt's PR ;)

I've tested the devfile in this PR, updating image to che-cpp-rhel7 and everything seems to work.

[tolusha]

I've fixed remarks and tested.
Everything works well.
@amisevsk @nickboldt
Could you approve the PR?

[amisevsk]

LGTM, thanks @tolusha

[nickboldt]

+1

[nickboldt]

squashed and merged.