Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add c/c++ base image based on... #100

Merged
merged 2 commits into from
Sep 24, 2019

Conversation

nickboldt
Copy link
Contributor

@nickboldt nickboldt commented Sep 23, 2019

Add c/c++ base image based on registry.centos.org/centos/devtoolset-7-toolchain-centos7; reorder containers in alpha sequence because yeah

Ref: eclipse-che/che#13698

Change-Id: I8d95000f756b948d29a6c935163097ccc44ade53
Signed-off-by: nickboldt nboldt@redhat.com

…-toolchain-centos7; reorder containers in alpha sequence because yeah

Change-Id: I8d95000f756b948d29a6c935163097ccc44ade53
Signed-off-by: nickboldt <nboldt@redhat.com>
@nickboldt
Copy link
Contributor Author

nickboldt commented Sep 23, 2019

Note that we could also use https://access.redhat.com/containers/?architecture&tab=docker-file#/registry.access.redhat.com/devtools/llvm-toolset-rhel7/images/7.0.1-34

but that's RHEL7, not UBI8, so not sure if there's much value-add there.

This PR blocks #73

Change-Id: If4f47e9f6b291bb4f19a243da2c4b5a08f5f5343
Signed-off-by: nickboldt <nboldt@redhat.com>
@amisevsk
Copy link
Contributor

Although for the main public repo I might prefer the centos-based image.

@amisevsk
Copy link
Contributor

Also, almost forgot but make sure the image repo is created in the quay org before merging.

@nickboldt
Copy link
Contributor Author

All things being equal, "I might prefer" the one I don't have to fork for productizing. :)

Any technical reasons to prefer the unsupported community version instead of the officially supported one, with all the bonus CVE fixin's?

@amisevsk
Copy link
Contributor

Hey now, I approved the PR :)

Any technical reasons to prefer the unsupported community version instead of the officially supported one, with all the bonus CVE fixin's?

Fear of RHEL/redistributing + historical process of "centos for public, rhel for subscription"? Mostly kidding, though using RHEL images in a freely re-distributable form is a relatively recent thing.

I went ahead and created https://quay.io/repository/eclipse/che-cpp-rhel7 to not block merging.

@nickboldt nickboldt merged commit fea6eec into eclipse-che:master Sep 24, 2019
sparkoo pushed a commit to sparkoo/che-devfile-registry that referenced this pull request Dec 4, 2020
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants