Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Customizing OpenShift Eclipse Che ConsoleLink #2666

Merged
merged 8 commits into from Dec 4, 2023
Merged

feat: Customizing OpenShift Eclipse Che ConsoleLink #2666

merged 8 commits into from Dec 4, 2023

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Nov 22, 2023

What does this pull request change?

Customizing OpenShift Eclipse Che ConsoleLink

What issues does this pull request fix or reference?

eclipse-che/che#22675
eclipse-che/che-operator#1788

Specify the version of the product this pull request applies to

main

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Copy link

github-actions bot commented Nov 22, 2023

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Nov 22, 2023

🎊 Navigate the preview: https://655f23a863efde5f167554c2--eclipse-che-docs-pr.netlify.app 🎊

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
:page-aliases: installation-guide:customizing-openshift-che-consolelink.adoc

[id="customizing-openshift-che-consolelink"]
= Customizing {ocp} {prod} ConsoleLink
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tolusha just wondering if Red Hap Application dropdown menu is also using ConsoleLink object or is it called smth. differently?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, which dropdown menu we are talking about?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-11-17 at 15 41 16

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Red Hap Application dropdown menu is based on ConsoleLink objects

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will fix the Vale issues

tolusha and others added 2 commits November 22, 2023 11:46
…r-a-configmap-as-a-subpath-into-a-container.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…r-a-configmap-as-a-subpath-into-a-container.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
@tolusha tolusha marked this pull request as ready for review November 22, 2023 13:11
@tolusha tolusha requested a review from a team as a code owner November 22, 2023 13:11
@tolusha
Copy link
Contributor Author

tolusha commented Nov 22, 2023

screenshot-console-openshift-console apps ci-ln-nwg595k-76ef8 aws-2 ci openshift org-2023 11 22-15_47_44

tolusha and others added 3 commits November 22, 2023 17:25
…onsolelink.adoc

Co-authored-by: Ilya Buziuk <ibuziuk@redhat.com>
…onsolelink.adoc

Co-authored-by: Ilya Buziuk <ibuziuk@redhat.com>
…onsolelink.adoc

Co-authored-by: Ilya Buziuk <ibuziuk@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Reviews automation moved this from Triage to Approved Dec 4, 2023
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tolusha tolusha merged commit 691b878 into main Dec 4, 2023
7 checks passed
Reviews automation moved this from Approved to Done Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Reviews
  
Done
5 participants