Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to mount secrets into che containers as subpath #1788

Merged
merged 2 commits into from Nov 22, 2023
Merged

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Nov 21, 2023

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Copy link

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (14eed75) 59.53% compared to head (e185052) 59.71%.

Files Patch % Lines
pkg/deploy/deployment.go 89.09% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1788      +/-   ##
==========================================
+ Coverage   59.53%   59.71%   +0.17%     
==========================================
  Files          71       71              
  Lines        8605     8658      +53     
==========================================
+ Hits         5123     5170      +47     
- Misses       3131     3133       +2     
- Partials      351      355       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tolusha tolusha merged commit afa38e2 into main Nov 22, 2023
23 checks passed
@tolusha tolusha deleted the 22675 branch November 22, 2023 11:56
@devstudio-release
Copy link

Build 3.11 :: operator_3.x/321: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: operator_3.x/321: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5351 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: copyIIBsToQuay/2184: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: sync-to-downstream_3.x/5352: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5223 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.11 :: operator-bundle_3.x/2312: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5352 triggered

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.x/4980: SUCCESS

Detected new images: rebuild operator-bundle
* devspaces-operator; /DS_CI/operator-bundle_3.x/2312 triggered

@devstudio-release
Copy link

Build 3.11 :: dsc_3.x/1578: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: copyIIBsToQuay/2184: SUCCESS

3.11
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.11-87
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.11-v4.14-626604-533291-s390x
  + quay.io/devspaces/iib:3.11-v4.14-s390x
  + quay.io/devspaces/iib:next-v4.14-s390x
  + quay.io/devspaces/iib:3.11-v4.13-626712-533286-s390x
  + quay.io/devspaces/iib:3.11-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.11-v4.12-626706-533281-s390x
  + quay.io/devspaces/iib:3.11-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  + quay.io/devspaces/iib:3.11-v4.11-626698-533277-s390x
  + quay.io/devspaces/iib:3.11-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.11-v4.14-626604-533291-x86_64
  + quay.io/devspaces/iib:3.11-v4.14-x86_64
  + quay.io/devspaces/iib:next-v4.14-x86_64
  + quay.io/devspaces/iib:3.11-v4.13-626712-533286-x86_64
  + quay.io/devspaces/iib:3.11-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.11-v4.12-626706-533281-x86_64
  + quay.io/devspaces/iib:3.11-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
  + quay.io/devspaces/iib:3.11-v4.11-626698-533277-x86_64
  + quay.io/devspaces/iib:3.11-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.11-v4.14-626604-533291-ppc64le
  + quay.io/devspaces/iib:3.11-v4.14-ppc64le
  + quay.io/devspaces/iib:next-v4.14-ppc64le
  + quay.io/devspaces/iib:3.11-v4.13-626712-533286-ppc64le
  + quay.io/devspaces/iib:3.11-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.11-v4.12-626706-533281-ppc64le
  + quay.io/devspaces/iib:3.11-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le
  + quay.io/devspaces/iib:3.11-v4.11-626698-533277-ppc64le
  + quay.io/devspaces/iib:3.11-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: copyIIBsToQuay/2186: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: sync-to-downstream_3.x/5354: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5225 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.11 :: operator-bundle_3.x/2313: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5354 triggered

@devstudio-release
Copy link

Build 3.11 :: dsc_3.x/1579: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: dsc_3.x/1579: SUCCESS

3.11.0-CI

@devstudio-release
Copy link

Build 3.11 :: copyIIBsToQuay/2186: SUCCESS

3.11
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.11-88
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.11-v4.14-626717-533291-s390x
  + quay.io/devspaces/iib:3.11-v4.14-s390x
  + quay.io/devspaces/iib:next-v4.14-s390x
  + quay.io/devspaces/iib:3.11-v4.13-626712-533286-s390x
  + quay.io/devspaces/iib:3.11-v4.12-626706-533281-s390x
  + quay.io/devspaces/iib:3.11-v4.11-626698-533277-s390x
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.11-v4.14-626717-533291-x86_64
  + quay.io/devspaces/iib:3.11-v4.14-x86_64
  + quay.io/devspaces/iib:next-v4.14-x86_64
  + quay.io/devspaces/iib:3.11-v4.13-626712-533286-x86_64
  + quay.io/devspaces/iib:3.11-v4.12-626706-533281-x86_64
  + quay.io/devspaces/iib:3.11-v4.11-626698-533277-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.11-v4.14-626717-533291-ppc64le
  + quay.io/devspaces/iib:3.11-v4.14-ppc64le
  + quay.io/devspaces/iib:next-v4.14-ppc64le
  + quay.io/devspaces/iib:3.11-v4.13-626712-533286-ppc64le
  + quay.io/devspaces/iib:3.11-v4.12-626706-533281-ppc64le
  + quay.io/devspaces/iib:3.11-v4.11-626698-533277-ppc64le

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants